208731 - possible improvements to nsCSSRect type

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

nsCSSRect could probably use a few more methods to simplify callers' use of it.
 In bug 125246 comment 45, bzbarsky wrote:

  1) Maybe add a function on nsCSSRect that returns true if and only if at least
     one of the members has non-null unit.
  2) Maybe add a Reset() function on nsCSSRect.

From bug 125246 comment 33:

  We may want to add a function on nsCSSRect that checks whether any of the
  sub-values is null.  We're ending up doing that check in a number of places...
  Maybe nsCSSRect::HasValue() or something?  (Not necessarily as part of this
  patch; I can file a separate bug on this.)

and:

  We may want a Reset() on nsCSSRect too (looking at ClearProperty here).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Something like this....

I looked around, and there wouldn't be any other callers of these functions at
the moment... that makes me somewhat question how much we need them, to be
truthful.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 127509 [details] [diff] [review]
Something like this....

On the other hand, I do think this makes the code more readable... David,
there's no rush on this review, clearly; I'd pick on someone else, but no one
else knows this code.  :(

Comment 3

[Boris Zbarsky [:bzbarsky]]

Taking.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Checked in.