208812 - Create events for internal accessibility clients

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Some accessibility clients will only use XPCOM to communicate with Gecko. They
need a way to be informed about accessibility events.

I'm going to use nsIObserver for this, topic = "accessible-event"

Comment 1

[Aaron Leventhal]

Attachment: Send events through nsIObserver. Create nsIAccessibleEvent for access to event data

Comment 2

[Kyle Yuan]

Comment on attachment 125248 [details] [diff] [review]
Send events through nsIObserver. Create nsIAccessibleEvent for access to event data

>+NS_IMETHODIMP nsDocAccessible::FireToolkitEvent(PRUint32 aEvent, nsIAccessible* aAccessible, void* aData)
>+{
>+ nsCOMPtr<nsIObserverService> obsService =
>+   do_GetService("@mozilla.org/observer-service;1");
>+ if (!obsService) {
>+   return NS_ERROR_FAILURE;
>+ }
>+
>+ nsIAccessibleEvent *accEvent = new nsAccessibleEventData(aEvent, aAccessible, this, aData);
>+ NS_ENSURE_TRUE(accEvent, NS_ERROR_OUT_OF_MEMORY);
>+
>+ NS_ADDREF(accEvent);
>+ return obsService->NotifyObservers(accEvent, NS_ACCESSIBLE_EVENT_TOPIC, nsnull);

r=kyle with above indent problem fixed.

Comment 3

[Aaron Leventhal]

Comment on attachment 125248 [details] [diff] [review]
Send events through nsIObserver. Create nsIAccessibleEvent for access to event data

Thanks Kyle. Will fix indent problem.

Comment 4

[Alec Flett]

Comment on attachment 125248 [details] [diff] [review]
Send events through nsIObserver. Create nsIAccessibleEvent for access to event data

sr=alecf

Comment 5

[Aaron Leventhal]

checked in

Comment 6

[Kyle Yuan]

Comment on attachment 125248 [details] [diff] [review]
Send events through nsIObserver. Create nsIAccessibleEvent for access to event data

For making the accessibility feature work better and more stable in 1.4.x, we
need to get this patch in. This fix has been in trunk for a long period. It
won't affect other modules.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 125248 [details] [diff] [review]
Send events through nsIObserver. Create nsIAccessibleEvent for access to event data

This is not going to make 1.4.1.  Please re-request aproval after 1.4.1 ships
if you'd like to get this in for 1.4.2. 
Kyle, can you all take this into your tree locally until after 1.4.1 ships
(real soon now) and then work with us to get it landed first thing for 1.4.2?