208834 - [ActiveX] control complains in in embedding dist that data: url is not supported

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[Adam Lock]

The Mozilla control uses a data: url to display a simple page in design mode in
the likes of VB. In the embedding dist, the data: protocol is not supported so
an error message is reported when the page is loaded.

The control should check first to see if the data protocol is supported before
loading it.

Comment 1

[Adam Lock]

Attachment: Patch

Patch checks there is a "data" protocol handler available before loading the
design mode URL

Comment 2

[Adam Lock]

Comment on attachment 125349 [details] [diff] [review]
Patch

Can I have an r/sr on this patch to the ActiveX control?

It tests whether the data: protocol is supported before loading a url of that
type. This is necessary because the data: protocol does not exist in GRE or
embedding dists.

This url is used to show a simple page when the control is set to design mode
(e.g. in the VB form designer)

Comment 3

[Darin Fisher]

Comment on attachment 125349 [details] [diff] [review]
Patch

r=darin

ah, the joys of the unknown protocol handler :-/

Comment 4

[Christopher Blizzard (:blizzard)]

Comment on attachment 125349 [details] [diff] [review]
Patch

sr=blizzard

(Boy does this give me the willies.)

Comment 5

[Adam Lock]

Fix is checked in