208842 - [AxPlugin] update .xpi installer to install nsAxSecurityPolicy.js and activex.js on Mozilla 1.4

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Adam Lock]

Update the install.js and xpi packager so that an ActiveX installer may easily
enable Mozilla 1.4 installs. This requires installing activex.js and
nsAxSecurityPolicy.js as well as more stringent version checking.

Comment 1

[Adam Lock]

Attachment: Patch

Install activex.js and nsAxSecurityPolicy.js in the xpi package

Comment 2

[Adam Lock]

Comment on attachment 125458 [details] [diff] [review]
Patch

Can I have an r/sr on this patch to update the XPI installer for the plugin to
include the security policy and settings files?

Thanks

Comment 3

[Alec Flett]

Comment on attachment 125458 [details] [diff] [review]
Patch

sr=alecf
I'm surprised there isn't an easier way, like adding these files to a manifest
file somewhere.

Comment 4

[David Bradley]

Comment on attachment 125458 [details] [diff] [review]
Patch

Does cancelInstall return? And if it does do you want to continue to install
the other files?

Comment 5

[Adam Lock]

Comment on attachment 125458 [details] [diff] [review]
Patch

I'm going to cancel the r/sr request and rewrite this thing. It could be
smaller and I think it shouldn't cancelInstall and then call performInstall. I
think the XPInstaller is smart enough to do the right thing but it doesn't look
right.

Comment 6

[Adam Lock]

Attachment: install.js

I rewrote the installer to make use of JS arrays and things to collapse some of
these statements down. I've also made it much more stringent in checking error
codes so that it won't call performInstall unless everything succeeds.

Comment 7

[Adam Lock]

Comment on attachment 125523 [details] [diff] [review]
install.js

David, can you review this rewritten install.js. I collapsed down the steps
into a loop that reads an array of objects representing each file to install.
I've also gotten put a single if / else test to performInstall / cancelInstall
at the bottom dependent on the value of err so both can't be called.

Comment 8

[David Bradley]

Comment on attachment 125523 [details] [diff] [review]
install.js

r=dbradley

Geesh, you'd think size calculation and space available determination would be
built into the install system

Comment 9

[Adam Lock]

Fix is checked in