Closed
Bug 208846
Opened 21 years ago
Closed 21 years ago
nsElementTable.cpp shouldn't hard code array lengths
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Whiteboard: [patch])
Attachments
(1 file)
15.58 KB,
patch
|
harishd
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
nsElementTable.cpp shouldn't hard code array lengths. This has caused one major bug (bug 182500) and has led to other incorrect patches that would have caused similar problems (bug 91927 comment 18). I'm going to attach a patch that fixes this a really ugly way (that was possible to do really easily). If someone else wants to do something nicer, feel free, but I think this should go in unless someone else does something nicer.
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #125255 -
Flags: review?(harishd)
Assignee | ||
Updated•21 years ago
|
Whiteboard: [patch]
Comment on attachment 125255 [details] [diff] [review] patch Very nice. I like this a lot. r=harishd
Attachment #125255 -
Flags: review?(harishd) → review+
Assignee | ||
Updated•21 years ago
|
Attachment #125255 -
Flags: superreview?(jst)
Comment 3•21 years ago
|
||
Comment on attachment 125255 [details] [diff] [review] patch sr=jst
Attachment #125255 -
Flags: superreview?(jst) → superreview+
Assignee | ||
Comment 4•21 years ago
|
||
Fix checked in to trunk, 2003-06-10 15:12 -0700.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•21 years ago
|
||
This turned out to be a codesize (well, data size) win: libhtmlpars.so Total: -2784 (+1470/-4254) Code: +32 (+32/+0) Data: -2816 (+1438/-4254)
You need to log in
before you can comment on or make changes to this bug.
Description
•