208854 - numerous functions declared in both cert.h and genname.h

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

Numerous functions are declared in both cert.h and genname.h.
Many of those functions are not exported.  This begs the questions:
1. Is genname.h public or private?

2. Should cert.h merely include genname.h, rather than duplicating its functions?

3. For each of the duplicated functions:  
   a. is it public or is it private?
   b. should it be declared in cert.h? or in genname.h?

Comment 1

[Wan-Teh Chang]

genname.h is a private header.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Taking bug.  I've already eliminated all but 2 duplicates.  

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Marking P2 for 3.9.  Patch forthcoming.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

This patch does 3 things:

1. Remove one of the two declarations of CERT_GetNamesLength from cert.h
2. Remove CERT_GetNamesLength from cert.h.  It is declared in genname.h.
3. Correct the descriptive comment for CERT_GetNamesLength in genname.h

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

In comment 4 above, my description of the patch was incorrect.
Item 1 should have read:

1. Remove one of the two declarations of CERT_GetCommonName from cert.h 

Comment 6

[Wan-Teh Chang]

Comment on attachment 132890 [details] [diff] [review]
patch v1

r=wtc.

By the way, in the previous comment, the function in item #1
should be CERT_GetCommonName.

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

/cvsroot/mozilla/security/nss/lib/certdb/genname.h,v  <--  genname.h
new revision: 1.6; previous revision: 1.5

/cvsroot/mozilla/security/nss/lib/certdb/cert.h,v  <--  cert.h
new revision: 1.39; previous revision: 1.38