208870 - remove :before search in nsCSSFrameConstructor::FindFrameWithContent()

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Hixie (not reading bugmail)]

dbaron asked that i file a bug about removing the following from 
   nsCSSFrameConstructor::FindFrameWithContent()
...:

            // Check if kidframe is the :before pseudo frame for aContent. If it
            // is, and aContent is an element, then aContent might be a
            // non-splittable-element, so the real primary frame could be the
            // next sibling.

            if (aContent->IsContentOfType(nsIContent::eELEMENT) &&
                nsLayoutUtils::IsGeneratedContentFor(aContent, kidFrame,
nsCSSPseudoElements::before)) {
              kidFrame->GetNextSibling(&kidFrame);
#ifdef DEBUG
              NS_ASSERTION(kidFrame, ":before with no next sibling");
              if (kidFrame) {
                nsCOMPtr<nsIContent> nextSiblingContent;
                kidFrame->GetContent(getter_AddRefs(nextSiblingContent));

                // Make sure the content matches, and because I'm paranoid,
                // make sure it's not the :after pseudo frame.

                NS_ASSERTION(nextSiblingContent.get() == aContent &&
                             !nsLayoutUtils::IsGeneratedContentFor(aContent,
kidFrame, nsCSSPseudoElements::after),
                             ":before frame not followed by primary frame");
              }
#endif
            }

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Taking.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(This code is no longer needed due to the changes for bug 141054.)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 125268 [details] [diff] [review]
patch

r+sr=me

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in to trunk, 2003-06-10 15:11 -0700.