208979 - txStylesheet::init ENSUREs on wrong variable

Status: RESOLVED FIXED

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Jag pointed out a bug in txStylesheet::init

http://lxr.mozilla.org/seamonkey/source/extensions/transformiix/source/xslt/txStylesheet.cpp#107

should use mCharactersTemplate, not mContainerTemplate.

And we should look into using something neater then the current |instrp =
&(*instrp)->mNext| syntax.

a = new A
NS_ENSURE_TRUE(a, ...)
b = new B
NS_ENSURE_TRUE(b, ...)
a->mNext = b;
c = new C
NS_ENSURE_TRUE(c, ...)
b->mNext = c

Though that makes it less clear that a linked list is being built

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: v1

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 125357 [details] [diff] [review]
v1

sr=jst

Comment 3

[Peter Van der Beken [:peterv]]

I won't be able to check this in any time soon, so feel free.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

-> peterv

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in