209037 - Bookmarklet "javascript:window.find()" is broken.

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Bob Perkins]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030529
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030529

Ref: http://bugzilla.mozilla.org/show_bug.cgi?id=9550
Ref: search toolkit.jar for "window.find()"

At one time, a method was implemented for calling up Mozilla's "Find in this
Page" dialog via a bookmarklet "javascript:window.find()" but that method no
longer appears to work. The dialog is called up, but Mozilla makes no attempt to
actually search for the text that is entered into the dialog box.

Reproducible: Always

Steps to Reproduce:
1. Create bookmarklet "javascript:window.find()"
2. Open a webpage containing text
3. Launch said bookmark
4. Enter text into "Find in this Page" dialog box
5. Click Find

Actual Results:  
Mozilla makes no effort to search document for text entered into "Find in this
Page" dialog box.

Expected Results:  
Mozilla should have searched the document for the text entered into the "Find in
this Page" dialog box.

A variety of other bookmarklets -- including "javascript:void(find())" and
"javascript:(function(){find();})()" -- work similarly, pulling up the FITP
dialog, only to have Mozilla ignore the requested search.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Sounds like a focus problem to me....  The content area does not have focus, so
the find dialog gets hooked up to nothing useful  (my guess).

Comment 2

[[e-mail]]

Using the JS console to force focus with
top.getTopWin().content.focus();top.getTopWin().content.find(); also fails.

Comment 3

[Bob Perkins]

I was just noticing that I may have quoted the script differently than what I
was using at the time. I think I was actually trying
"javascript:void(window.find())" when I came to the conclusion that there must
be a problem somewhere.

Interestingly, "javascript:window.find()" works flawlessly in Netscape 4.79, as
does the simpler "javascript:find()", as does "javascript:void(find())", as does
"javascript:(function(){find();})()". So there are at least four different ways
of accomplishing the task in NN4, but none that work in Mozilla.

Comment 4

[Daniel Wang]

I can't get window.find() to work within web page as well. moz2004013108/win2k

Comment 5

[Harshal Pradhan]

Attachment: Testcase

This shows that this only happens when the find dialog is involved.
window.find('some text') works fine.

Comment 6

[Harshal Pradhan]

This is not a DOM bug. Looks like a regression from bug 127589.

Comment 7

[[e-mail]]

Attachment: Proposed patch

The way that the find dialog was testing for how it was opened caused this:
JavaScript error:
chrome://global/content/finddialog.js line 91: invalid 'instanceof' operand
window.opener.nsFindInstData

Comment 8

[jag (Peter Annema)]

Comment on attachment 140368 [details] [diff] [review]
Proposed patch

sr=jag.

Comment 9

[[e-mail]]

Fix checked in.

Comment 10

[Martijn Wargers (dead)]

Attachment: patch for Firefox

This was never fixed for Firefox. The bookmarklet case is an instance where the
old find dialog is still used.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 196181 [details] [diff] [review]
patch for Firefox

please don't request approval until you've got appropriate reviews.

Comment 12

[Martijn Wargers (dead)]

Comment on attachment 196181 [details] [diff] [review]
patch for Firefox

This should be safe, since this patch is already since very long in Seamonkey.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/toolkit/content/finddialog.js; new revision: 1.12;

Comment 14

[Mike Schroepfer]

Comment on attachment 196181 [details] [diff] [review]
patch for Firefox

Per bug meeting - approved for 1.8b5 branch.

Comment 15

[:Gavin Sharp [email: [e-mail]]]

1.8 Branch:
mozilla/toolkit/content/finddialog.js; new revision: 1.11.10.1;