Closed Bug 209087 Opened 21 years ago Closed 21 years ago

Content interfaces' out parameters should use ptr-to-ptrs instead of ref-to-ptrs

Categories

(Core :: DOM: Core & HTML, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: caillon, Assigned: caillon)

Details

Attachments

(2 files, 2 obsolete files)

Touching nsIAttribute, nsI*Content, nsIDocument, nsIDocumentViewer,
nsINameSpace*, nsINodeInfo*

Johnny said he's okay with this.  Patch to follow.
Attached file Patch (tar.gz) (obsolete) —
Attachment #125452 - Flags: superreview?(jst)
Attachment #125452 - Flags: review?(jst)
Attached file Patch v2 (tar.gz) (obsolete) —
Also deCOMtaminate three methods on nsINodeInfo.
Attachment #125452 - Attachment is obsolete: true
Attachment #125452 - Flags: superreview?(jst)
Attachment #125452 - Flags: review?(jst)
Attachment #125487 - Flags: superreview?(jst)
Attachment #125487 - Flags: review?(jst)
Attached file Patch v3 (tar.gz)
Incorporates some comments from Johnny:

- use HasAttr instead of GetAttr in one place where we don't care about the
value.
- use swap() in tight loops
- foo->bar(getter_AddRefs(foo)); may break on some platform/compilers
Attachment #125487 - Attachment is obsolete: true
Attachment #125487 - Flags: superreview?(jst)
Attachment #125487 - Flags: review?(jst)
Comment on attachment 125545 [details]
Patch v3 (tar.gz)

Rheeeet!
Attachment #125545 - Flags: superreview?
Attachment #125545 - Flags: review?
Attachment #125545 - Flags: superreview?(jst)
Attachment #125545 - Flags: superreview?
Attachment #125545 - Flags: review?(jst)
Attachment #125545 - Flags: review?
Comment on attachment 125545 [details]
Patch v3 (tar.gz)

r+sr=jst
Attachment #125545 - Flags: superreview?(jst)
Attachment #125545 - Flags: superreview+
Attachment #125545 - Flags: review?(jst)
Attachment #125545 - Flags: review+
The changes to GetBaseURL caused a crash in the (eHTMLUnit_String ==
aBaseHref.GetUnit()) case because |url| went out of scope before |*aBaseURL|
was |AddRef|ed.  It fixes a crash I'm seeing on a mail message (and probably on
many other testcases).	I'm going to check it in without review in the hopes
that it makes the 9pm builds.
Comment on attachment 125616 [details] [diff] [review]
patch to fix crash regression in nsGenericHTMLElement::GetBaseURL

sr=jst
Attachment #125616 - Flags: superreview+
Ah, thanks for fixing that silly mistake, David.

Marking this as fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: