Closed
Bug 209087
Opened 21 years ago
Closed 21 years ago
Content interfaces' out parameters should use ptr-to-ptrs instead of ref-to-ptrs
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: caillon, Assigned: caillon)
Details
Attachments
(2 files, 2 obsolete files)
117.76 KB,
application/x-gzip
|
jst
:
review+
jst
:
superreview+
|
Details |
1.46 KB,
patch
|
jst
:
superreview+
|
Details | Diff | Splinter Review |
Touching nsIAttribute, nsI*Content, nsIDocument, nsIDocumentViewer, nsINameSpace*, nsINodeInfo* Johnny said he's okay with this. Patch to follow.
Assignee | ||
Comment 1•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #125452 -
Flags: superreview?(jst)
Attachment #125452 -
Flags: review?(jst)
Assignee | ||
Comment 2•21 years ago
|
||
Also deCOMtaminate three methods on nsINodeInfo.
Attachment #125452 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Attachment #125452 -
Flags: superreview?(jst)
Attachment #125452 -
Flags: review?(jst)
Assignee | ||
Updated•21 years ago
|
Attachment #125487 -
Flags: superreview?(jst)
Attachment #125487 -
Flags: review?(jst)
Assignee | ||
Comment 3•21 years ago
|
||
Incorporates some comments from Johnny: - use HasAttr instead of GetAttr in one place where we don't care about the value. - use swap() in tight loops - foo->bar(getter_AddRefs(foo)); may break on some platform/compilers
Assignee | ||
Updated•21 years ago
|
Attachment #125487 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Attachment #125487 -
Flags: superreview?(jst)
Attachment #125487 -
Flags: review?(jst)
Assignee | ||
Comment 4•21 years ago
|
||
Comment on attachment 125545 [details]
Patch v3 (tar.gz)
Rheeeet!
Attachment #125545 -
Flags: superreview?
Attachment #125545 -
Flags: review?
Assignee | ||
Updated•21 years ago
|
Attachment #125545 -
Flags: superreview?(jst)
Attachment #125545 -
Flags: superreview?
Attachment #125545 -
Flags: review?(jst)
Attachment #125545 -
Flags: review?
Comment 5•21 years ago
|
||
Comment on attachment 125545 [details]
Patch v3 (tar.gz)
r+sr=jst
Attachment #125545 -
Flags: superreview?(jst)
Attachment #125545 -
Flags: superreview+
Attachment #125545 -
Flags: review?(jst)
Attachment #125545 -
Flags: review+
The changes to GetBaseURL caused a crash in the (eHTMLUnit_String == aBaseHref.GetUnit()) case because |url| went out of scope before |*aBaseURL| was |AddRef|ed. It fixes a crash I'm seeing on a mail message (and probably on many other testcases). I'm going to check it in without review in the hopes that it makes the 9pm builds.
Comment 7•21 years ago
|
||
Comment on attachment 125616 [details] [diff] [review] patch to fix crash regression in nsGenericHTMLElement::GetBaseURL sr=jst
Attachment #125616 -
Flags: superreview+
Assignee | ||
Comment 8•21 years ago
|
||
Ah, thanks for fixing that silly mistake, David. Marking this as fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•