209174 - Unlocalizable word in the list of events

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Pavel Cvrcek (inactive account - please use [e-mail])]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; cs-CZ; rv:1.4) Gecko/20030529
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; cs-CZ; rv:1.4) Gecko/20030529

File: content/unifinder.js

if( calendarEvent.allDay )
{
  startText = "All day " + startDate;
}

and

if( calendarEvent.allDay )
{
endText = "All day " + endDate;
}


Text "All day" cannot be localized.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Michael Wolf]

Yes, but there ar still more such hardcoded strings in .js files. In
unifinder.js  Title:, Start: End: and Description: are defined (besides "all
Day) as hardcoded strings displayed as quick info. There should be defined any
entities which can be localized.
But, I think also in other .js or .xul files are such hardcoded strings that
should be replaced by entities.

Comment 2

[Eric Belhaire]

Attachment: patch of unifinder.js calendar.xul calendar.dtd

Comment 3

[Eric Belhaire]

Comment on attachment 126369 [details] [diff] [review]
patch of unifinder.js calendar.xul calendar.dtd

I don't know how to correct the patch but the lines :
+  var unifinderAlldayLabel = "&calendar.unifinder.allday.label";
+  var unifinderTitleLabel = "&calendar.unifinder.title.label";
+  var unifinderStartLabel = "&calendar.unifinder.start.label";
+  var unifinderEndLabel = "&calendar.unifinder.end.label";
+  var unifinderDescriptionLabel = "&calendar.unifinder.description.label";

should be replace by :
+  var unifinderAlldayLabel = "&calendar.unifinder.allday.label";
+  var unifinderTitleLabel = "&calendar.unifinder.title.label;";
+  var unifinderStartLabel = "&calendar.unifinder.start.label;";
+  var unifinderEndLabel = "&calendar.unifinder.end.label;";
+  var unifinderDescriptionLabel = "&calendar.unifinder.description.label;";

Comment 4

[Eric Belhaire]

Comment on attachment 126369 [details] [diff] [review]
patch of unifinder.js calendar.xul calendar.dtd

Second chance :-)

+  var unifinderAlldayLabel = "&calendar.unifinder.allday.label;";
+  var unifinderTitleLabel = "&calendar.unifinder.title.label;";
+  var unifinderStartLabel = "&calendar.unifinder.start.label;";
+  var unifinderEndLabel = "&calendar.unifinder.end.label;";
+  var unifinderDescriptionLabel = "&calendar.unifinder.description.label;";

Comment 5

[Mike Potter]

This patch won't apply.  Please try again using patch -Urn

Comment 6

[Mike Potter]

Comment on attachment 126369 [details] [diff] [review]
patch of unifinder.js calendar.xul calendar.dtd

Can't apply, please make new patch.

Comment 7

[Eric Belhaire]

Attachment: patch of unifinder.js calendar.xul calendar.dtd

second chance :-;

Comment 8

[Mike Potter]

Comment on attachment 126579 [details] [diff] [review]
patch of unifinder.js calendar.xul calendar.dtd

Checked in cvs.

Comment 9

[Mike Potter]

Fixed in cvs.

Comment 10

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!