209359 - HRs cause wrong style context parent warnings

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

HRs cause wrong style context parent warnings thanks to the fix for bug 141054.

(My testcase was a mail message, but anyway.)

The patch I'm about to attach fixes those warnings.  It also moves some code
around since Bernd put an unrelated function in the middle of some related ones
(which I reviewed), and also fixes the final "tail call" to be true recursion,
since the placeholder's parent could be NS_FRAME_IS_SPECIAL.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Oops, forgot about next-in-flows.

If you think of a better name for |GetNextSiblingHarder|, let me know.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 125623 [details] [diff] [review]
patch

r+sr=me.  You suggested GetNextSiblingAcrossLines instead of
GetNextSiblingHarder; that would be much better, yes.  ;)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: additional patch

Actually, the :before itself could be split...

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: additional patch

better version

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-06-14 17:55/18:24 -0700.