209375 - Form apparently submitted twice; second time empty

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect)

Description

[Jonas Linde]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5a) Gecko/20030612
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5a) Gecko/20030612

This page is for booking train tickets. (It's in Swedish but it's a fairly
obvious form.) When I enter my travel information and click on the OK button I
get the same form again with all the form fields empty. After reviewing the
network traffic (with Ethereal) it seems like the form is actually submitted
twice; once correctly and once empty. It works flawlessly with any 1.4 (or
earlier) build. The problem didn't occur until immediately after the 1.5 branch.

Reproducible: Always

Steps to Reproduce:
1. Fill in some stations from the two drop downs on the right
2. Click the "Tur & Retur" (return trip) radio button
3. Click the OK button at the bottom (next to the big red arrow)
4. Sometimes this will get you to the correct page for entering the return trip
date; choose a return date and click OK again
Actual Results:  
The original form is shown again without any form data

Expected Results:  
The next form should be shown allowing me to select a return trip and then pick
a departure time from the list of suggestions.

Working: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030611

Not working: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5a) Gecko/20030612


Reproducibility is actually "Almost every time" as it occasionally works for at
least a few form submissions; I have never been able to complete the booking of
a ticket though.

Comment 1

[Jonas Linde]

Attachment: Etherreal TCP trace of bad case

Note the extra GET near the end.

Comment 2

[Jonas Linde]

Attachment: Etherreal TCP trace of good case

Comment 3

[Jonas Linde]

I've researched this a bit further; when loading a form containing an input of
type "image" the page is immediately requested again via a GET. I.e. it is not
actually a form _submission_ bug but a form _parsing_ bug. I'm not sure which
component that would be though.

There seems to be a race condition involved concerning which of the requests
that actually gets displayed in the browser.

Comment 4

[Jonas Linde]

Attachment: Simple CGI script that gets requested twice

Comment 5

[Jesiah S]

I see this on LInux 2003062305 

Comment 6

[Jonas Linde]

changing component to Form Manager as per comment #3

Comment 7

[Jonas Linde]

Attachment: asp test case

Here's a test case for this bug. It's available in the wild att
http://www.init.se/~jonas/bug209375.asp

If you click on the POST button a couple of times you'll see both counters
getting incremented. In Mozilla 1.4 only one counter at a time gets incremented
which of course is the expected behaviour.

Comment 8

[Jonas Linde]

*** Bug 212518 has been marked as a duplicate of this bug. ***

Comment 9

[Jonas Linde]

Attachment: This patch resolves the problem

It comes from bug 212518 which is a duplicate of this bug.

Comment 10

[Stefan [:stefanh]]

*** Bug 209764 has been marked as a duplicate of this bug. ***

Comment 11

[Stefan [:stefanh]]

Reassigning...

Comment 12

[Jonas Linde]

This bug got fixed on July 22 by some other bugfix; possibly by the fix for bug
213333.

Comment 13

[Hasham]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9) Gecko/2008061004 Firefox/3.0

Verified.