209485 - [FIX]View source eats parts of CDATA sections when ']' encountered

Status: RESOLVED FIXED

(Core Graveyard :: View Source, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Typical XBL markup:

<constructor>
  <![CDATA[
     var foo = Components.classes["contractfoo"];
     var bar = 5;
  ]]>
</constructor>

When one views the source, everything between the first ']' and the ending '>'
is dropped, due to the patch that was checked in for bug 130045.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed change

This does not make things completely correct, but it should fix the 99% case
for scripts in XML...

To do this completely correctly, view-source would need to use a real XML
tokenizer for XML content.

Comment 2

[[e-mail]]

Just pointing out another reason to use an XML parser:
view-source: doesn't handle extended doctypes properly e.g.
<!DOCTYPE bindings [
<!ENTITY % tabBrowserDTD SYSTEM "chrome://global/locale/tabbrowser.dtd" >
%tabBrowserDTD
]>

Comment 3

[harishd]

Comment on attachment 125702 [details] [diff] [review]
Proposed change

r=harishd

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 125702 [details] [diff] [review]
Proposed change

jst, could you sr?

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 125702 [details] [diff] [review]
Proposed change

sr=jst

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed.