209495 - convert all_day_event* gifs to pngs

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, enhancement)

Description

[Jim Davis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030529
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030529

The white square around the "all_day_event" star is kind of distracting, so I
converted the three GIFs involved to PNGs with partial transparency and modified
calendar.css to reflect the file name changes--seems to work fine here.

Is this a bad thing?  I'm too big an idiot to submit a patch.

Reproducible: Always

Steps to Reproduce:
...
Actual Results:  
...

Expected Results:  
...

Comment 1

[Jim Davis]

Attachment: replacement for 'all_day_event.gif'

Comment 2

[Jim Davis]

Attachment: replacement for 'all_day_event_hover.gif'

Comment 3

[Jim Davis]

Attachment: replacement for 'all_day_event_down.gif'

Crud, too late now, I should've zipped these into one.	I'm sorry for the spam.

Comment 4

[Eric Belhaire]

I tried it after replacing all_day_eventXXXXX.gif by all_day_eventXXXXX.png in
skin/modern/calendar.css skin/classic/calendar.css and it works well and looks
very nice. 

I nevertheless have got a question : why do you move from gif to png (I think
that it is possible to do transparency with gif) ?
Otherwise, could you provide a patch for the calendar.css (it will help Mike, I
think).

Comment 5

[Jim Davis]

Attachment: Patch to the two calendar.css files involved

Why png instead of gif?  First, there's the whopping 54-byte savings on the
three files (heh), and more importantly, alpha channel support.

While a gif could handle an image with transparent parts, it simply wouldn't
blend as smoothly with different backgrounds like a png would.

As for submitting a patch, well... I'm reading up on that now.	I know nothing
about CVS, so I'm having to start from scratch.  (I hope I did this right...
"cvs checkout (files)", change the files, "cvs diff -u > patchfile"?)

Comment 6

[Eric Belhaire]

Your patch looks pretty good. 
You should now :
- "Edit" your patch (Actions->Edit in the Attachement table last column) 
- flag first-review to "?" with "[e-mail]" as a requestee.
- Mike Potter will then receive the notification that you submitted a patch and
that you ask for review.

Comment 7

[Jim Davis]

Comment on attachment 125979 [details] [diff] [review]
Patch to the two calendar.css files involved

Thanks!  Done.

Comment 8

[Mike Potter]

When adding or removing files from cvs, you also need to modify the jar.mn file.

Comment 9

[Mike Potter]

OK, I've modified the jar.mn file, everything is checked into cvs.

Comment 10

[Simon Paquet [:sipaq]]

Comment on attachment 125979 [details] [diff] [review]
Patch to the two calendar.css files involved

Patch was checked in.

Comment 11

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!