209513 - Mozilla doesn't handle some text/html files correctly

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Jure Repinc (JLP)]

Mozilla doesn't know how to handle text/html files on some sites. It displays
application helper dialog asking you what to do with this file. I think that
this started to be a problem from build 20030614 as a build from 20030613 works
just fine.

Reproducable: always

Steps to reproduce:
1. Open Mozilla
2. Try to open http://mirror.ati.com/support/faq/index.html
or go to http://www.ati.com/ and try clicking on any link

Actual Result:
Mozilla displays a helper application dialog telling you that it can't handle
files of type text/html and asking you what to do.

Expected result:
Mozilla should just display the page.

Comment 1

[Hermann Schwab]

confirming on Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5a) Gecko/20030614
last tested build ID working: 2003061311
first tested Build ID notworking: 2003061408

Comment 2

[Jure Repinc (JLP)]

I also see similar errors with images. For example on this page I get this error
for some add image:
http://www.3dxtreme.org/

Comment 3

[Vedran Miletic]

AFAIK, doesn't happen in 1.4.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Jungshik, this got broken by your changes for bug 162765 (in particular, by the
"do not pass the length" changes, since I assume that given the header:

Content-Disposition: filename=index.html

(which is what we have here), it comes out with "filename=index.html" for
dispToken, whereas the old code came out with "filename").

Perhaps we should go back to passing a length for the 'filename' check... that
case is all about handling broken servers anyway....

In any case, could you add parens around the two string checks, so that instead
of (a || b && c) you have (a || (b && c)) ?  Much more readable that way.

Comment 5

[Jungshik Shin]

Attachment: 2-liner patch

bz, if you like it, let me have a quick review.
BTW, EqualsIgnorecase() should take care of cases where dispToken is shorter
than 6 chars, right?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Yes.  Except "filename" has 8 letters, not 6... ;)

Comment 7

[Jungshik Shin]

Comment on attachment 125785 [details] [diff] [review]
2-liner patch

Oops. I thouhgt I could count. Apparently, I can't sometimes :-)

>+           !dispToken.EqualsIgnoreCase("filename", 6)))
>+ !dispToken.EqualsIgnoreCase("filename", 6))) 

With 6 replaced by 8 in two places, let me have  r/sr so that I can get this
in.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 125785 [details] [diff] [review]
2-liner patch

With that change, looks good.

Comment 9

[Jungshik Shin]

Fix checked in. Marking as fixed.