209550 - bad position when use <statusbar/> inside <wizard/>

Status: RESOLVED WONTFIX

(Core :: XUL, defect)

Description

[Ariel Fatecha]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130

wizard doesn't inserts anything under buttons-box (ok, cancel, etc), but
statusbar must be in window's bottom place.

Reproducible: Always

Steps to Reproduce:
1.open test-case
2.see where <statusbar> is placed


Actual Results:  
<statusbar> is placed over buttons-box

Expected Results:  
<statusbar> must be placed under buttons-box

I'll post patch for this bug.

Comment 1

[Ariel Fatecha]

Attachment: test-case

must be runned from chrome.

Comment 2

[Ariel Fatecha]

Attachment: patch for this

posted patch. ;)

Comment 3

[Frederic Bezies]

*** Bug 209552 has been marked as a duplicate of this bug. ***

Comment 4

[Ariel Fatecha]

cc-spam ;)

Comment 5

[Jan Varga [:janv]]

I wonder if it is actually a good idea to use <statusbar> in <wizard>

Comment 6

[Ariel Fatecha]

I found that good for feedback about small things.

Comment 7

[Jan Varga [:janv]]

You need to talk to other people then, because I'm not sure if this is right
thing to do.

Comment 8

[Ariel Fatecha]

I think <statusbar> must be in bottom of window (or have the change to do it at
least). 
No matter if is good looking or not.
Jan, please let know if this bug is to right place to talk about or I would have
to write in news.

Comment 9

[[e-mail]]

Comment on attachment 125748 [details] [diff] [review]
patch for this

Waiting for a definitive ruling.

Comment 10

[jag (Peter Annema)]

This change seems okay to me, I don't think many people are going to use
<statusbar> in <wizard>, and those who are will most likely want it below the
buttons, not above. Hmmm, what if someone puts a <statusbar> in a <wizardpage>,
does that get pulled down to the bottom by this change too?

Comment 11

[Ariel Fatecha]

no, because <children> only look for inside one level, it doesn't pulled down
too, I had tested.

Comment 12

[:deanis74]

If that's the case, this seems fine to me, too (not that it really matters, but
I like to hear myself talk).

Comment 13

[[e-mail]]

Comment on attachment 125748 [details] [diff] [review]
patch for this

Whoever checks this in should remove the trailing w/s.

Comment 14

[jag (Peter Annema)]

Comment on attachment 125748 [details] [diff] [review]
patch for this

sr=jag

Comment 15

[Ariel Fatecha]

Neil, can you commit in cvs this? because I can't do it.

Comment 16

[[e-mail]]

Fix checked in.

Comment 17

[Matt Clay]

It appears that this patch never made it into Firefox.

Comment 18

[Ariel Fatecha]

(In reply to comment #17)
> It appears that this patch never made it into Firefox.

true. Neil, can you commit this for Firefox?

Comment 19

[[e-mail]]

(In reply to comment #18)
>Neil, can you commit this for Firefox?
I think it would need separate Firefox review.

Comment 20

[Ariel Fatecha]

I agree. I will add a new patch for review.

Comment 21

[Ariel Fatecha]

Attachment: Patch for firefox

Comment 22

[Mike Connor [:mconnor]]

Comment on attachment 213892 [details] [diff] [review]
Patch for firefox

When merging the toolkit bindings was brought up, we said no to this.  If you want to add something oddball like a statusbar to a wizard, you can just extend the wizard bindings to include it in your own code.

Comment 23

[Ariel Fatecha]

ok, no for Firefox.