209679 - remove NotifyReflowObservers

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Alec Flett]

so I just found this lovely code while reviewing another bug, which calls out to
the observer service to notify observers about all reflow events! This seems
like a waste, and like bloat.

it is more than likely totally unnecessary, and it dates back to 14-May-2000 - I
can only imagine there used to be supporting code elsewhere in the tree.

patch forthcoming.

Comment 1

[Christopher Hoess (gone)]

->Layout: Misc Code

Comment 2

[Alec Flett]

Attachment: make it debug-only

Maybe this should go away completely, I don't know. But it surely doesn't need
to be in a release build. I'll let dbaron decide.

Comment 3

[Alec Flett]

Comment on attachment 136803 [details] [diff] [review]
make it debug-only

dbaron, should we kill this entirely, or just make it debug-only? Nobody is
listening to this notification.

Comment 4

[Alec Flett]

Comment on attachment 136803 [details] [diff] [review]
make it debug-only

dbaron, should we kill this entirely, or just make it debug-only? Nobody is
listening to this notification.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'd say remove it entirely.  I hope no embedder is using it -- might be worth
posting about...

Comment 6

[Boris Zbarsky [:bzbarsky]]

Alec, do you have time to drive this in for 1.7a, or should someone else take over?

Comment 7

[Alec Flett]

oh, I can totally do this for 1.7a

Comment 8

[Alec Flett]

message posted to .embedding and .layout on 12/10/2003

patch to remove the observer notifications coming up.

Comment 9

[Alec Flett]

Attachment: remove them entirely, along with topics

and here's the patch that removes them entirely. Looking for reviews..
(dbaron?)

Comment 10

[Olivier Cahagne]

setting 1.7b '?' flag as patch is ready for review since Dec'03.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Um...

1)  The patch HAS review.  That's pretty obvious, no?
2)  The patch was checked in on Jan 7, 2004.   That could be checked with about 3
    minutes worth of effort.

This bug is fixed, as far as I can tell, so marking fixed.

Comment 12

[Alec Flett]

oops, thanks