Closed Bug 20973 Opened 25 years ago Closed 24 years ago

Finish hooking up Table Properties dialog

Categories

(Core :: DOM: Editor, defect, P1)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
VERIFIED DUPLICATE of bug 45756

People

(Reporter: cmanske, Assigned: cmanske)

References

Details

(Whiteboard: [nsbeta2+][8/2]) 

Need to complete:
Selecting cell, row, column, or entire table from a menu
Join Cells and Split Cell.
Table Properties dialog.
Status: NEW → ASSIGNED
Target Milestone: M15
Summary: Implement missing table editing behavior and Table Properties dialog → [feature]Implement missing table editing behavior and Table Properties dialog
Target Milestone: M15 → M14
Changing to M14.
*** Bug 24017 has been marked as a duplicate of this bug. ***
Target Milestone: M14 → M15
moving to m15 - load balance
Target Milestone: M15 → M14
moving back to m14
Getting table editing to work when colspan=0 and/or rowspan=0 depends on fix
for 24880
Depends on: 24880
I'm setting the keyword to beta1 -- however, not all of this needs to be in for 
beta -- functions such as join and split can be done in m15/m16
Keywords: beta1
Whiteboard: [PDT-]
If parts of table editing will not be implemented for Beta 1, let's remove any 
UI that might be in place.  Beta 1 UI should be simple and all functional.
*** Bug 27314 has been marked as a duplicate of this bug. ***
just adding here: need ability to change table cell color
Target Milestone: M14 → M15
Table dialog is not complete enough for M14. Menu items and toolbar access
are disabled in case we can't do any more work on it for Beta1.
*** Bug 28147 has been marked as a duplicate of this bug. ***
We've got to get our essential UI features working. I was not able to finish
the Table Dialog in time for M14 deadline. I did not want to rush in my 
current work. This really should be done for Beta1. The table dialog layout 
problems mentioned in bug 24880 were because of changes in the layout system 
that require rewriting of the dialog using new XUL box behavior that wasn't
available until 2 days before the close of M14. We will never deliver a
quality product if we can't develop our UI. If we can't checkin UI changes,
bugs in the widgetes cannot be revealed. I could go on, but I will continue
this in another forum tomorrow.
Requesting consideration by PTD team.
Keywords: dogfood
Whiteboard: [PDT-] → [pdt-]
Target Milestone: M15 → M14
Remove status whiteboard pdt- to get this back on the PDT's radar.

Please make this bug PDT+ so that Charley can fix the following things:
  * add OK/Cancel buttons which are missing (no way to dismiss modal dialog!)
  * enable setting/removing of table borders
  * change column/row width/height values
  * span a cell for more than 1 column/row

These are considered minimal necessary changes according to Bijal.
OS: Windows NT → All
Hardware: PC → All
Whiteboard: [pdt-]
testing 
PDT+ for the ok/cancel buttons. Also ok to solve by disabling the dialog if 
you prefer. PDT- for everything else for beta1 and dogfood.
Whiteboard: [PDT+] for ok/cancel problem only
It's not that simple. The OK/Cancel buttons are there, but the entire dialog
is not layed out correctly, so the buttons are outside the dialog window.
The work requires rewriting the entire dialog to use boxes, not tables,
as I mentioned above.


What has been decided?  Are we rewriting the dialog?
Do you plan to fix "table select row"?  It was reported as a problem in the 
bug-o-rama.
The table dialog should not have been used at all in the bug-o-rama.
It was an extremely preliminary version.
I'm working on it right now and should be ready by 2/21.
removing PDT+ and beta1 keyword; move to M16 (post-beta1)
Keywords: beta1
Whiteboard: [PDT+] for ok/cancel problem only
Target Milestone: M14 → M16
Putting on PDT- radar for dogfood.
Whiteboard: [PDT-]
Work is mostly done and will be checked in during M15
Target Milestone: M16 → M15
Clearing beta1 and PDT- for work we know will be after beta1
Whiteboard: [PDT-]
Adding PDT- for dogfood.  Does not need an immediate fix.
Whiteboard: [PDT-]
Getting close, but still work to do in Table Dialog.
Moving to next milestone
Target Milestone: M15 → M16
updating keyword and status whiteboard to reflect that this is a beta 2 feature 
work bug that the Composer team deems a must fix for beta 2.
Severity: normal → major
Keywords: dogfood → beta2
Priority: P3 → P1
Whiteboard: [PDT-] → Composer feature work
Keywords: nsbeta2
[nsbeta2+ until 5/16]
Whiteboard: Composer feature work → [nsbeta2+ until 5/16] Composer feature work
*** Bug 38975 has been marked as a duplicate of this bug. ***
*** Bug 38879 has been marked as a duplicate of this bug. ***
All core table editing is completed.
The table dialog is not, but this is a much better known problem and, of course,
must be finished. The dialog exists, but needs some xul tweaking. The JS needs
to be finished to set all the table attributes correctly.
Should we separate the dialog work into a separate bug or just changed
summary on this (bugs on table editing behavior can be files separately, 
of course).

*** Bug 40205 has been marked as a duplicate of this bug. ***
update whiteboard, updating summary too
Summary: [feature]Implement missing table editing behavior and Table Properties dialog → Finish hooking up Table Properties dialog
Whiteboard: [nsbeta2+ until 5/16] Composer feature work → [nsbeta2+]IN nsbeta2
*** Bug 42279 has been marked as a duplicate of this bug. ***
Depends on: 42264
M16 has been out for a while now, these bugs target milestones need to be 
updated.
moving over to m17, adjusted priority and severity
Severity: major → critical
Whiteboard: [nsbeta2+]IN nsbeta2 → [nsbeta2+]
Target Milestone: M16 → M17
Adding myself to cc: list.
added fix by date in status
Whiteboard: [nsbeta2+] → [nsbeta2+][8/2]
All functionality should work now.
Only known problem is that we can't insert a <caption> element.
I'll file a separate bug for that problem, which shouldn't hold up nsbeta2.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
table props doesn't come up...using 7/12 build.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
it does come up if you click on Table button on toolbar...just doesn't
come up from Table | Table Properties menu item.
Let's just close this bug, intended to track major table dialog work.
If there are remaining problems, file new bugs on those issues.
I tried to investigate the problem of "Properties" not working from the Table
 menu, but too many assertions are getting in the way. I'll continue 
investigating when I return from vacation (8/1/00).
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
verified in 7/17 build.
Status: RESOLVED → VERIFIED
Build: 2000-08-09-09m18

It doesn't work again!
If you RT click in a table you can't bring up the table properties dialog nor is 
it acessable form the menu.
Status: VERIFIED → REOPENED
Keywords: nsbeta3
Resolution: FIXED → ---
The launching from the Table menu (Table Properties item) is covered by bug
45756. It also doesn't come up from the context menu because it's not 
implemented yet (bug 43307).
It does work if you put caret in a table and click on the table toolbar
button, or use the "Cell Properties" item which should show in the Format menu.


*** This bug has been marked as a duplicate of 45756 ***
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → DUPLICATE
verified in 8/10 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.