209753 - indent and outdent need a serious rewrite

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

preliminary note : this bug is covering four serious issues about indent
and outdent, in particular in the cases of lists. Some of the issues are already
covered by other bugs but since the whole code dealing with this is quite tiny,
and since I will attach here one fix for all issues, I prefer duping old bugs
to the current one.

ISSUE 1, BOTH HTML AND CSS MODE

   1. make a numbered list of three items
   2. indent second item
   3. indent third item

   expected result:      1. first item
                            1. second item
                            2. third item

   actual result:        1. first item
                            1. second item
                            1. third item

ISSUE 2, BOTH HTML AND CSS MODE

   1. make a numbered list of three items
   2. indent THIRD item
   3. then indent second item

   expected result:      1. first item
                            1. second item
                            2. third item

   actual result:        1. first item
                            1. second item
                            1. third item

ISSUE 3, CSS MODE ONLY:

   1. type some text in css mode
   2. indent four times and press return

   expected result: outdent button is enabled
   actual result:   outdent button is disabled

ISSUE 4, CSS MODE ONLY:

   1. create a list of three items and select it through the struct toolbar
   2. indent four times
   3. outdent once

   expected result: list remains indented 3 times
   actual result:   all indentation is removed

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: fix #1

Comment 2

[Joe Francis]

There are also problems like case #4 that dont involve lists.  CSS outdent is
broken whenever inline content seperated by <br>s is outdented.  There is an
open bug on this that I think is on Daniels list.

Comment 3

[Kathleen :Brade]

Comment on attachment 126117 [details] [diff] [review]
fix #1

I know this isn't a regression from this patch but I can't tell from this patch
either:
  Is it a problem that we don't initialize curBlockQuoteIsIndentedWithCSS
before the for loop?

r=brade; asking jfrancis to review

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

This is fixed in 2007-10-02 build.