Closed Bug 209911 Opened 22 years ago Closed 22 years ago

XUL tree blob sort ignores sort direction

Categories

(Core :: XUL, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

In nsXULTreeBuilder::CompareMatches, here are some sample lines: 1918 // Literals? 1938 return result * mSortDirection; 1944 // Dates? 1963 return result * mSortDirection; 1969 // Integers? 1980 return result * mSortDirection; 1986 // Blobs? (We can only compare these reasonably if we have a 1987 // collation object.) 2000 return result; Oops.
Attached patch Proposed patchSplinter Review
Attachment #126001 - Flags: superreview?(jaggernaut)
Attachment #126001 - Flags: review?(varga)
Attachment #126001 - Flags: review?(varga) → review+
-> Neil
Assignee: varga → neil.parkwaycc.co.uk
Comment on attachment 126001 [details] [diff] [review] Proposed patch sr=jag
Attachment #126001 - Flags: superreview?(jaggernaut) → superreview+
Fix checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: