Closed Bug 210141 Opened 21 years ago Closed 21 years ago

JAVASCRIPT_GLOBAL_PROPERTY_CATEGORY stuff shouldn't be readonly

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.5beta

People

(Reporter: axel, Assigned: jst)

References

Details

(Whiteboard: [HAVE FIX])

Attachments

(1 file)

nsDOMClassInfo.cpp should :JS_DefineUCProperty global properties registered
with the component manager as JSPROP_ENUMERATE, not
JSPROP_ENUMERATE | JSPROP_READONLY.

This way, js scripts can still use the variable name. The current code throws a
redeclaration of const
error on var foo;

jst has a patch for that.
Attached patch Proposed fix.Splinter Review
Attachment #126328 - Flags: superreview?(peterv)
Attachment #126328 - Flags: review?(axel)
Status: NEW → ASSIGNED
Whiteboard: [HAVE FIX]
Target Milestone: --- → mozilla1.5beta
Comment on attachment 126328 [details] [diff] [review]
Proposed fix.

r=me.
(btw, peterv said he'd be mostly out of reach for the next two weeks.)
Attachment #126328 - Flags: review?(axel) → review+
Comment on attachment 126328 [details] [diff] [review]
Proposed fix.

Oh, right... Boris, could you sr?
Attachment #126328 - Flags: superreview?(peterv) → superreview?(bzbarsky)
Attachment #126328 - Flags: superreview?(bzbarsky) → superreview+
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: