210222 - %21%21channelname%21%21 causes cz to return no such channel when added to autostartup but manually joining #!!channelname!! works fine cz does reports !! as %21%21 but fails to reckognize it unless attached to server

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Porter Jordan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030620
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030620

%21%21channelname%21%21 causes cz to return no such channel when added to
autostartup but  manually joining #!!channelname!! works fine cz does reports !!
as %21%21  but fails to reckognize it unless attached to server

Reproducible: Always

Steps to Reproduce:
1.manually join at !!channelname!! and add it to auto join at startup
2.when it is added CZ sees the !! as %21%21
3.when you start your session error message will return that as not a valid channel
but you can then /join #!!channelname!! and there is no problem.

Actual Results:  
when you start your session error message will return that as not a valid channel
but you can then /join #!!channelname!! and there is no problem.

Expected Results:  
/join #!!channelname!!

reported error on #Chatzilla

Comment 1

[James Ross]

The problem lies here:
http://lxr.mozilla.org/mozilla/source/extensions/irc/js/lib/irc.js#1967

The problem is ChatZilla was not realising ! was special, so just blindly
removed the # to get the shorter URL. However, since the character after the #
*is* special, it must have the # prefix (%23). Patch in a minute.

Comment 2

[James Ross]

Attachment: Makes getURL only drop the # when the following character is safe

Comment 3

[Robert Ginda]

Comment on attachment 141189 [details] [diff] [review]
Makes getURL only drop the # when the following character is safe

Shouldn't we be using the prefixes from RPL_ISUPPORT?

Your call, r=rginda either way

Comment 4

[James Ross]

Comment on attachment 141189 [details] [diff] [review]
Makes getURL only drop the # when the following character is safe

Checked in.

Comment 5

[James Ross]

Checked in --> FIXED.