210443 - nsImageLoadingContent shouldn't malloc as much...

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Johnny Stenback (:jst)]

When nsImageLoadingContent started using dummly requests to ensure proper
delivery of onload events in documents with images, one more malloc per image
was introduced. This can be eliminated with some not-too-clean
nsDummyLayoutRequest usage, patch coming up, and while this ain't the cleanest
thing to do, I think it's worth doing until we have a better way...

Comment 1

[Johnny Stenback (:jst)]

Attachment: Make ImageEvent inherit nsDummyLayoutRequest :-)

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 126330 [details] [diff] [review]
Make ImageEvent inherit nsDummyLayoutRequest :-)

Try not to puke :-)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 126330 [details] [diff] [review]
Make ImageEvent inherit nsDummyLayoutRequest :-)

sr=me assuming you change "itsefl" to "itself".  Truth to tell, I was
considering doing something like this with load events in general, at some
point in the remote past.... ;)

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 126330 [details] [diff] [review]
Make ImageEvent inherit nsDummyLayoutRequest :-)

>+  // The event will own itsefl while it's in the event Q, once

What bz said, and also spell out queue.  Or use |eventQ| (no spaces) to match
the variable name.

puke=caillon

Comment 5

[Johnny Stenback (:jst)]

FIXED.