Closed Bug 210713 Opened 21 years ago Closed 21 years ago

[gtk2] leaks in nsWindow and nsAppShell

Categories

(Core Graveyard :: GFX: Gtk, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dwitte, Assigned: dwitte)

Details

(Keywords: memory-leak)

Attachments

(1 file)

patch forthcoming to fix the following leaks:

PR_Malloc
PL_NewHashTable
nsAppShell::ListenToEventQueue(nsIEventQueue*, int)
[...]

PR_Malloc
PL_HashTableRawAdd
PL_HashTableAdd
nsAppShell::ListenToEventQueue(nsIEventQueue*, int)
[...]

g_malloc
gdk_cursor_new_for_display
gdk_cursor_new
nsWindow::SetCursor(nsCursor)
[...]
Attached patch patchSplinter Review
Comment on attachment 126505 [details] [diff] [review]
patch

blizzard, any chance you could take a look at this? I copied most of the code
from widget/src/gtk, so hopefully it's okay. (I also use gdk_cursor_unref()
instead of gdk_cursor_destroy() since the gtk2 references say the latter is
deprecated).

If you'd like dougt to review, feel free to bump it over to him.
Attachment #126505 - Flags: superreview?(blizzard)
Attachment #126505 - Flags: review?(blizzard)
Comment on attachment 126505 [details] [diff] [review]
patch

r+sr=blizzard
Attachment #126505 - Flags: superreview?(blizzard)
Attachment #126505 - Flags: superreview+
Attachment #126505 - Flags: review?(blizzard)
Attachment #126505 - Flags: review+
fixed - thx!
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: