210730 - Can optimize ClassInfoData::GetName a little in failure case

Status: RESOLVED FIXED

(Core :: Security: CAPS, defect)

Description

[jag (Peter Annema)]

Comment 1

[jag (Peter Annema)]

Attachment: Remember failure in mName

Comment 2

[jag (Peter Annema)]

Attachment: Or you could do this

Comment 3

[jag (Peter Annema)]

Hmm, and looking at GetFlags, mDidGetFlags should also be set to PR_TRUE for the
|else| case, since there's no way other than the constructor to set mClassInfo.

Comment 4

[Johnny Stenback (:jst)]

Attachment: ignore this.

Comment 5

[jag (Peter Annema)]

Comment on attachment 126583 [details] [diff] [review]
ignore this.

You'll end up freeing memory you don't own (|aName|).

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 126583 [details] [diff] [review]
ignore this.

This is obviously not a good day to be writing code.

Comment 7

[Johnny Stenback (:jst)]

Attachment: This should do it (diff -w)

Comment 8

[jag (Peter Annema)]

Comment on attachment 126585 [details] [diff] [review]
This should do it (diff -w)

r+sr=jag

Comment 9

[Johnny Stenback (:jst)]

Fixed.