Closed Bug 210910 Opened 22 years ago Closed 22 years ago

Right-clicking a file within a bookmarks folder in the bookmarks menu or toolbar makes that folder inaccessible

Categories

(Firefox :: Bookmarks & History, defect, P2)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firebird0.8

People

(Reporter: hao2lian.bugzilla, Assigned: p_ch)

References

Details

(Keywords: regression, Whiteboard: its a bug, we get the point, no more confirmations needed, thanks!)

Attachments

(2 files)

Closes open bookmark folder menus manually before dispatching a command
727 bytes, patch
Details | Diff | Splinter Review
Close menu when click on or outside context menu
1006 bytes, patch
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5a) Gecko/20030627 Mozilla Firebird/0.6 Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5a) Gecko/20030627 Mozilla Firebird/0.6 Bookmark folders have been acting strangely for recent builds. Right-clicking a file within a folder makes that folder and all its parents unopenable for that session. Restarting Firebird is a workaround. Can be reproduced both in the toolbar and in the Bookmarks menu. Some users may not experience this but I do. Reproducible: Always Steps to Reproduce:
More information: it appears that after you right-click the file and you unfocus the folder, the folder still remains focused although the bookmarks aren't visible. You can tell by looking at the icon which should remain in selected mode.
Confirmed WinME Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.5a) Gecko/20030627 Mozilla Firebird/0.6
Confirmed on Win2k SP4. Could be related to bug 197227.
OS: Windows 98 → All
Hardware: PC → All
Does anyone know when the last good build about this bug is?
I can confirm this on W2KPROSP4, using: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030628 Mozilla Firebird/0.6
Also on Windows 98 SE Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5a) Gecko/20030627 Mozilla Firebird/0.6
A temporary workaround, instead of restarting your browser, is to right-click the "stuck" folder and select "Collapse" from the context menu that pops up. That's how I've been getting around it in the 20030626 build under WinXP, anyhow.
Last good build is probably 6/25 although it had some nasty bugs in it.
Keywords: regression
*** Bug 210933 has been marked as a duplicate of this bug. ***
Easy Workaround: Press ESC. That takes the focus away from the bookmarks.
*** Bug 211542 has been marked as a duplicate of this bug. ***
I can also confirm this on W2K. Further investigation shows, that this bug was introduced with the 2003-06-21 build. Firebird 0.6 (2003-05-16) and the 2003-06-20 build both work fine. I don't think that this bug is related with bug 197227, since it worked until 06-21. I tried to identify the corresponding checkin, which broke this, but I couldn't find one. Perhaps someone with a better knowledge if the code can find it. I used the following query for bonsai: http://bonsai.mozilla.org/cvsquery.cgi?sortby=Date&date=explicit&mindate=06%2F20%2F2003+00%3A00%3A00&maxdate=06%2F21%2F2003+07%3A59%3A59
*** Bug 212349 has been marked as a duplicate of this bug. ***
*** Bug 212382 has been marked as a duplicate of this bug. ***
*** Bug 212699 has been marked as a duplicate of this bug. ***
Chanial: -> 0.7?
-> august
Target Milestone: --- → Firebird0.7
Confirmed on Linux (2003-07-18). Apparently, Firebird thinks the menu has not collapsed. A workaround for the toolbar is to right-click on the unopenable menu, then click on 'Collapse'.
*** Bug 213135 has been marked as a duplicate of this bug. ***
*** Bug 212944 has been marked as a duplicate of this bug. ***
*** Bug 213317 has been marked as a duplicate of this bug. ***
*** Bug 213694 has been marked as a duplicate of this bug. ***
*** Bug 213953 has been marked as a duplicate of this bug. ***
Blocks: 213965
the "collapse" trick doesn't work on folders in the Bookmarks menu. they remain locked - icons in the "open" state, but no menu popup. and for some reason, the Bookmarks Toolbar Folder doesn't have the Expand/Collapse options. 2003-07-27-16-1.5a on windows 2000
taking QA contact, sorry about the bugspam
QA Contact: asa → mconnor
VARIANT: When I right-click a menu in bookmarks, while a SUBMENU is open, then click outside of the bookmarks to make the menu disappear, the SUBMENU stays onscreen.
Re: comment 26 Anthony, you are describing either bug 197112 or bug 203183. Separate issues than this bug.
*** Bug 214588 has been marked as a duplicate of this bug. ***
*** Bug 214616 has been marked as a duplicate of this bug. ***
*** Bug 214559 has been marked as a duplicate of this bug. ***
Blocks: 214559
No longer blocks: 214559
*** Bug 214559 has been marked as a duplicate of this bug. ***
Also, using Firebird 0.6.1 binary windows on Windows XP, this occurs. However, if you attempt to use collapse on the folder after its stuck, it only displays expand. Clicking expand does nothing. And yes, the icon does show the book open.
*** Bug 214876 has been marked as a duplicate of this bug. ***
No longer blocks: 213965
*** Bug 197227 has been marked as a duplicate of this bug. ***
Blocks: 214881
*** Bug 214977 has been marked as a duplicate of this bug. ***
I can confirm all reported troubles on WinXP Pro with all latest updates for release 0.6.1. Closing and reopening the program is the only workaround I have found that works for me. Although the folders have an expanded icon next to them, only the Expand right click menu option is available, not the Collapse.
workaround: Press TAB button.
Can confirm Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030731 Mozilla Firebird/0.6.1 StumbleUpon/1.79 Also, when the folder is stuck my location bar will not accept keystrokes.
"Additional 'I see this too'...comments are unnecessary unless they are on a different platform or a significantly different build." Bugzilla Etiquette, http://bugzilla.mozilla.org/page.cgi?id=etiquette.html Can we please stop spamming everyone's email reconfirming that this bug exists. We know that it exists. That's why it is an unresolved bug.
*** Bug 215035 has been marked as a duplicate of this bug. ***
The same thing happens with 6.1 (binary build from mozilla.org) on Libranet 2.8 GNU/Linux. Moreover, the keyboard also becomes totally unresponsive. I cannot type in the location or the search bars or in any web forms and no keyboard shortcuts (Ctrl-T etc) work and neither do Page up and Page down. The keyboard only works in the bookmark properties fields. I'd also noticed the keyboard becoming unresponsive after minimising Firebird while a page was being loaded. However, that happened quite erratically and I had a quick workaround for it - Opening and closing the Cutomise Toolbar window seemed to get rid of the problem. But that does not seem to work when in this case.
Whiteboard: its a bug, we get the point, no more confirmations needed, thanks!
What's happening is that the context menu on the popup menu is rolling up, the rollup action calls nsMenuPopup::DismissChain which usually dismisses a chain of menus BUT since the context menu is an independently rooted popup menu, not in the chain of the toolbar menu popup, DismissChain is never called on the toolbar menupopup. The toolbar menupopup still goes away since the rollup is handled at the widget level. "Good Times." Pierre, I'm just going to grab this oen for now since it's not really bookmarks related.
Assignee: chanial → bugs
Status: NEW → ASSIGNED
Priority: -- → P2
Another bug that it blocks.
Blocks: 197227
Dave said he was going to take this for .8. He didn't want to do it in .7 because it's too risky of a change (widget/layout-xul-menus) to take this close to 1.5
Assignee: bugs → hyatt
Status: ASSIGNED → NEW
Target Milestone: Firebird0.7 → Firebird0.8
I just want to clear something up (as far as I can do it). Perhaps I am wrong, but as far as I understand. Bug 197227 is a bug in a feature introduced with post-Phoenix 0.5 nightlies, it has always existed, this feature never worked correctly. This bug (bug 210910) describes a recent regression (after 20030625 probably) that caused the folder after right clicking to become inacessible. That's all. The behavoiour folder not collapsing is bug 197227. So, these bugs are not the same thing. They are related to each other, that's for sure, they could even be related even to bug 197112, but they are certainly not duplicates. Just my 0.02€ :)
No longer blocks: 197227
*** Bug 197227 has been marked as a duplicate of this bug. ***
There's no problem in the bookmarks sidebar and the bookmarks manager, right? -> Narrowing summary by adding "in the bookmarks menu or toolbar".
Summary: Right-clicking a file within a bookmarks folder makes that folder inaccessible → Right-clicking a file within a bookmarks folder in the bookmarks menu or toolbar makes that folder inaccessible
Then it's certainly related to bug 197112, and fix for that bug (created today) might even do something to this one. Maybe not, who knows.
The patch hyatt posted to http://bugzilla.mozilla.org/show_bug.cgi?id=197112 fixes this bug.
Jamez is right, we figured that out together on IRC. The weird thing is, that the patch intended to fix 197112 fixes this bug here, but not bug 197112 :)
*** Bug 215744 has been marked as a duplicate of this bug. ***
Argh...confused this one with bug 197112. This patch (also posted uselessly to 197112) is intended for this bug. Thanks to Simon and Jamez for pointing this out. Let's try this again.
Comment on attachment 129573 [details] [diff] [review] Closes open bookmark folder menus manually before dispatching a command Hyatt, review? I know you've been around this code lately.
Attachment #129573 - Flags: review?(hyatt)
Does this fix regression this bug was originally filed for or just the non-closing bug that has existed for a long time?
I did a linux build of the 11-Aug source and did a patch using the attachment above by .. hyatt? I'm not sure who wrote the patch, but it appears to work well regarding the original problem stated in this bug. I can't see that it aggravates any other problems or causes new bugs, but it sure is a pleasure to be able to use the bookmarks-right-click-context stuff and have it keep on working again.
So Mac doesn't work correctly at all, either with or without this patch. I guess that's a separate issue. I'm inclined to just turn the context menus off on mac, since they can only be used on the personal toolbar subfolders anyway, and it's not like a Mac user would ever assume they could do this anyway.
Hyatt, could we just disable on Mac and go with this patch to fix the visible issue on Win32/Linux before 0.7, then do the big changes early for 0.8? I don't think we should ship 0.7 with such a high-visibility issue if at all possible. Alternatively, if context menus are going to break bookmarks anyway, maybe we should just disable them until this is fixed? While you can get it back via the folder context menu, users won't know this and will scream bloody murder, along with filing lots of duplicate bugs.
*** Bug 216070 has been marked as a duplicate of this bug. ***
I agree with Mike. This bug is highly visible, the unusually high number of dupes (21 at the moment) indicates that.
I agree, this is too big of an issue to leave in the next milestone release. It should be fixed ASAP, as it is stopping many people (including me) from using newer builds.
Sure, we can check in the hack. It's worth noting that the context menus don't behave properly on Win32 either. The behavior should be that the context menu disappears, but the bookmarks menu stays open. This hack will actually force the bookmarks menu closed, which is wrong. Still, we can take it for 0.7, since it at leasts gets us back to 0.6 parity, even though the behavior is incorrect.
I'm afraid taking the hack will only leave it there to be forgotten - Resulting in this bug never getting fixed properly.
Tom, that won't happen, since we won't close the bug until its fixed properly. This is part of a bigger issue with other bugs also affected, see the tracker this blocks for other bugs created by the context menu problems. And given the choice between the hack and shipping 0.7 with this bug intact, I think everyone's in agreement on the logical point of view.
*** Bug 216328 has been marked as a duplicate of this bug. ***
*** Bug 216607 has been marked as a duplicate of this bug. ***
*** Bug 216622 has been marked as a duplicate of this bug. ***
*** Bug 216771 has been marked as a duplicate of this bug. ***
I too have confirmed this is a problem in the main 0.6.1 build. I'm sure others have already reported it. I'm running Win2kSP4: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1
Bug still present Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030823 Mozilla Firebird/0.6.1+
*** Bug 217166 has been marked as a duplicate of this bug. ***
*** Bug 217237 has been marked as a duplicate of this bug. ***
*** Bug 217326 has been marked as a duplicate of this bug. ***
Target Milestone: Firebird0.8 → Firebird0.7
Workaround checked in...moving to 0.8. (By the way, the workaround doesn't cover the case where you dismiss the context menu without choosing a command. Still better than nothing though.)
Target Milestone: Firebird0.7 → Firebird0.8
I just installed Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030827 Mozilla Firebird/0.6.1+ which is supposed to have this workaround included. I see absolutely zero difference. I tried right clicking on an item and opening properties and then closing the properties window and that left the bookmark folder in the open and not visible state. I also tried right clicking on a bookmarked entry and selcting open and that did not leave the folder accessable from the menu anymore either.
Here's a thought. Can we just fix it so that a right click at this point does nothing? Assuming of course that we can do that and still have the right click option work in manage bookmarks. And then put the right click feature back in after 0.7? That way at least people won't do this accidentally and need to restart the browser to access their bookmarks.
*** Bug 217594 has been marked as a duplicate of this bug. ***
*** Bug 217618 has been marked as a duplicate of this bug. ***
re: Comment #75. i think it's better to have a user know that this is supposed to work and doesn't rather than the user starts filing bugs because nothing happens. you then get twice as many *extra* bug reports and have to start explaining that nothing happens on purpose. personally, if that was implimented i wouldn't upgrade, since i'd prefer to be able to right click in the first place, even if it broke something. new users would just put up threads and/or bugs about nothing happening, and why doesn't it do anything? ie does. ;)
That is just the point. Right now you can't right click. Or you can if you only want to do it once per session and never use a bookmark in that foler again. So if you want to be able to right click you need to go back to abuild where it worked. Right now if you right click, then you need to exit and restart firebird in order to get bookmarks to work at all.
William, if the folder is on the bookmarks toolbar, it will collapse properly if you manually collapse it, a restart is not required. With the hack that's in now, this problem will only occur if you right-click, then click elsewhere to dimiss the dialog. Choosing any of the context items will collapse the bookmark folder completely, but at least its collapsed. Disabling this completely would cause more headaches, and I'd be the one reading dozens of bugs about right-click not working :)
The workaround works fine as far as decribed in comment 73 and comment 80. Using Damian's unofficial 20030828 build on WinXP.
But isn't this exactly the same way it worked without the patch? I thought clicking on colapse for folders on the toolbar always worked. The issue people are complaining about is that if you click on bookmarks in the manu toolbar and then select one of the folders from there (like quick searches) and right click on one of those choices (like google quicksearch) then you can no longer use any of the quick search bookmarks without restarting firebird. There is no collapse menu choice on the right click of a folder in this case. In fact even though it shows as open the expand choice is still present.
I suspect the real issue with my continuing problem is that although Bonsai shows this bug as being fixed in the 8/27 nightly I think it really missed the cutoff for the windows build, so I think I just need to wait for the 8/29 build to see how the workaround works.
William, Blake checked in the workaround at 08/27 12:03. The official 08/27 was built around 08:00 that day, because it's in the directory 2003-08-27-08-trunk. The file date is 9:19 if you have a look at http://komodo.mozilla.org/pub/firebird/nightly/latest-trunk/ (I find it pretty irritating that ftp.mozilla.org adds 3 hours to that.) Well, the workaround didn't made it that day.
OK I downloaded an optimized build that actually has the workaround patch in it. This still leaves the problem if you right click on an item and then click outside the menu box to dismiss the window. But this is much better as long as you remember that if you do right click and then decide not to select any of the choices you should either select something inocuous like copy or use the esacpe key to close the menu. So I guess it seems reasonable to leave it this way until it is fixed for real in 0.8.
*** Bug 218114 has been marked as a duplicate of this bug. ***
Please take care about the chevron ">>"-problem (first reported with bug #214559) - the current checked-in workaround doesn't seem to cover it, at least on my system the chevron stays expanded and can only get to normal state by clicking <ESC> or <TAB>. Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.5b) Gecko/20030903 Firebird/0.6.1+
*** Bug 218262 has been marked as a duplicate of this bug. ***
*** Bug 218354 has been marked as a duplicate of this bug. ***
Another workaround: If a folder or sub folder is in the 'locked' state as described above, try dragging on it a bookmark or the urlbar icon, go on dragging onto another folder then go back on the locked folder (then drag the bookmark somewhere where nothing will happen, usually the title bar). The folder is again accessible. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030903 Firebird/0.6.1+ This workaround worked with previous builds, too.
This patch also closes the bookmark menu if the mouse is clicked outside the context menu, as noted in comment 85 For developers the patch should fix the problem. For non developers, this is how to make the change to an installed Firebird (v0.6.1) 1. jar -xvf (or unzip) chrome/browser.jar 2. Edit content/browser/bookmarks/bookmarksMenu.js 3. Add a new function (closeAllBookmarks) and call it twice at the end of destroyContextMenu(), i.e. destroyContextMenu: function (aEvent) { if (content) content.focus() BookmarksMenuDNDObserver.onDragRemoveFeedBack(document.popupNode); // needed on cancel aEvent.target.removeEventListener("mousemove", BookmarksMenuController.onMouseMove, false) BookmarksMenu.closeAllBookmarks(document.getElementById("bookmarks-menu").firstChild); BookmarksMenu.closeAllBookmarks(document.getElementById("bookmarks-ptf").firstChild); }, ///////////////////////////////////////////////////////////////////////////// // Ensure all bookmark popups are closed closeAllBookmarks: function (item) { while (item) { BookmarksMenu.closeAllBookmarks(item.firstChild); if (item.localName == "menupopup") item.hidePopup(); item = item.nextSibling; } }, 4. jar -cv0f (or zip) the content directory back into chrome/browser.jar
I may be doing it wrong, but I followed the above directions and couldn't get the patch to work. In fact, all it did was render a small gray box instead of showing the context menu. Will this not work on nightlies after 0.6.1? I'm using 20030910.
it works for me on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030903 Firebird/0.6.1+
*** Bug 219137 has been marked as a duplicate of this bug. ***
*** Bug 219297 has been marked as a duplicate of this bug. ***
Re comment #91 - that patch works beautifully, thank you Greg. I applied it to my own "special" build of the 0.6.1 milestone, and this bug stopped dead in its tracks.
*** Bug 219511 has been marked as a duplicate of this bug. ***
*** Bug 219481 has been marked as a duplicate of this bug. ***
*** Bug 219581 has been marked as a duplicate of this bug. ***
*** Bug 219582 has been marked as a duplicate of this bug. ***
*** Bug 219050 has been marked as a duplicate of this bug. ***
*** Bug 219837 has been marked as a duplicate of this bug. ***
*** Bug 219871 has been marked as a duplicate of this bug. ***
*** Bug 219989 has been marked as a duplicate of this bug. ***
*** Bug 220019 has been marked as a duplicate of this bug. ***
Is this gonna get checked in or what? The patch works beautifully for me.
*** Bug 220564 has been marked as a duplicate of this bug. ***
Blocks: majorbugs
*** Bug 220668 has been marked as a duplicate of this bug. ***
*** Bug 220748 has been marked as a duplicate of this bug. ***
*** Bug 220912 has been marked as a duplicate of this bug. ***
*** Bug 221038 has been marked as a duplicate of this bug. ***
*** Bug 221276 has been marked as a duplicate of this bug. ***
*** Bug 221291 has been marked as a duplicate of this bug. ***
*** Bug 221473 has been marked as a duplicate of this bug. ***
*** Bug 221536 has been marked as a duplicate of this bug. ***
*** Bug 222770 has been marked as a duplicate of this bug. ***
*** Bug 222772 has been marked as a duplicate of this bug. ***
Any chance of getting a patch checked in any time soon? The second patch (greg, comment 85) has been working very nicely for me since I've started building my own. It seems to be more or less fixed, just pending checkin. The endless complaints and dupe bugs would finally die off.
Correction: I meant comment 91. Sorry.
that's not really "fixing" the problem though, the entire menu shouldn't collapse because you clicked on a context menu. The fix is much more involved, and needs to happen to fix other bugs as well.
Blocks: 217695
No longer blocks: 217695
*** Bug 217695 has been marked as a duplicate of this bug. ***
*** Bug 222862 has been marked as a duplicate of this bug. ***
*** Bug 222907 has been marked as a duplicate of this bug. ***
*** Bug 224508 has been marked as a duplicate of this bug. ***
*** Bug 225227 has been marked as a duplicate of this bug. ***
*** Bug 226168 has been marked as a duplicate of this bug. ***
Bug 225431 (a fix for which was checked in today) Sounds very similar to what is going on here. Perhaps the solution is similar as well?
that fix is similar to what we already have, but its not the proper fix the proper fix DOESn'T collapse all the menus, just the context menu.
*** Bug 227102 has been marked as a duplicate of this bug. ***
Blocks: 227034
Flags: blocking0.8?
*** Bug 227750 has been marked as a duplicate of this bug. ***
Flags: blocking0.8? → blocking0.8+
This is so annoying, especially for newbies to the browser. Needs to be fixed.
Your post contributed absolutely nothing to this bug. Neither does this one. Please refrain from Me Too posts.
Brian, stop messing with blocking flags. Only the developers decide whether a bug blocks a release or not.
Flags: blocking0.8+ → blocking0.8?
Many apologies. I figured the blocking0.8 flag was meant as a vote sort of. BugZilla's confusing that way. And I figured I'd try setting it anyway, and if it was something I wasn't supposed to do, I wouldn't be allowed to do it. BZ probably shouldn't allow you to do something you're not supposed to. ANYWAY, with regards to the bug... Only unofficial builds sport the fix?
I'm using the following OS/2 build: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.5) Gecko/20031015 Firebird/0.7 and I don't see the behaviour described. I can Right-Click bookmarks as much as I like, and everything still continues to work. I wonder if this means the bug is platform-specific, of if this build fixed it?
Right clicking might work, but if you right-clic and do delete in a folder on the personal toolbar Firebird freezes. /Toni
Problem still exists with: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031209 Firebird/0.7+ When i open a folder within the PTB, right click on a bookmark inside this opened menu and click again at the PTB the folder stays pushed till i select 'Collapse'.
*** Bug 228369 has been marked as a duplicate of this bug. ***
It pains me to do this, but no time before this release. -> 0.9
Target Milestone: Firebird0.8 → Firebird0.9
It might just be me, but I thought Firebird was released according to bug fixes not dates, sounds right now like you are trying to reach a deadline...
Az: Things change. The world will not end.
*** Bug 228680 has been marked as a duplicate of this bug. ***
taking
Assignee: hyatt → p_ch
fixed on trunk (well, test well), but not yet on the branch. It was a combination of focus subtleties and browser.xul indentation spoofing. CHAMPAGNE POUR TOUS !!! (and a big thanks to the QA and all the people that duped so many bug reports!)
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
As a sidenote, the changes have made the UI much more responsive (focusing, bookmarks context menu, selection etc.) because the bm command controller attached to |window| was slowing us down significantly :o)
Pierre- If you can land this on the branch, don't forget to retarget it for 0.8. And I do hope you can hit branch for this pesky thing. And fiddle with the blocking0.8, please :-D -Alan
Pierre, I'm not sure this was under this bug, but if you rightclick some folder under bookmarks (with your patch checked in on today's build of mine on linux), and click on properties, it becomes invisible the next time you try it. I guess I don't know if the workaround was just to allow escaping the context menu or if the idea was to fix the bug.
I don't think that this patch works. If I right click on a file in a folder (in the bookmarks section of the manu bar), the folder still becomes inaccssible. WinXP, Athlon 1400, 640 MB RAM, Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031219 Firebird/0.7+ (Nova: MNG,DOMi,Venkman)
Mickey: you're right, I've now corrected this case. This bug is fixed on the 0.8 branch.
Thanks, Pierre. I'll try a building again tomorrow.
Target Milestone: Firebird0.9 → Firebird0.8
*** Bug 230419 has been marked as a duplicate of this bug. ***
*** Bug 232178 has been marked as a duplicate of this bug. ***
Status: RESOLVED → VERIFIED
*** Bug 218115 has been marked as a duplicate of this bug. ***
Pre-release cleanup
Flags: blocking0.8? → blocking0.8+
*** Bug 232683 has been marked as a duplicate of this bug. ***
*** Bug 233181 has been marked as a duplicate of this bug. ***
I'm still getting this bug with this build Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040207 Firebird/0.8.0+ (scragz) New profile and no extensions.
(In reply to comment #157) > I'm still getting this bug with this build > Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040207 > Firebird/0.8.0+ (scragz) > > New profile and no extensions. Confirmed.
-Works on 20040204 (AEbrahim's build) -Broken on 20040205/20040207/20040207 (Scragz's builds) So something that happened between 20040204 and 20040205 must have got this broken again.
Is this in any build other than Scragz's? He seems to think that it's his fault, and it will be fixed tomorrow. http://forums.mozillazine.org/viewtopic.php?p=363148#363148
(In reply to comment #160) > Is this in any build other than Scragz's? He seems to think that it's his fault, > and it will be fixed tomorrow. > > http://forums.mozillazine.org/viewtopic.php?p=363148#363148 yes, I found this bug too in cypher77's 2004-02-07
I get this error in javascript console when I right click a bookmark Error: uncaught exception: [Exception... "Node was not found" code: "8" nsresult: "0x80530008 (NS_ERROR_DOM_NOT_FOUND_ERR)" location: "chrome://browser/content/bookmarks/bookmarksMenu.js Line: 32"] Anyway I still see this bug with Mozilla/5.0 (Windows; U; Windows NT 5.1; en- US; rv:1.7a) Gecko/20040210 Firefox/0.8.0+ (djeter)
I still see this bug with the trunk 20040213 build of firefox 0.8+ One observation: If I right click on an inaccessible folder in the bookmarks and click "expand", the folder will be come accessible again. Anybody else is sseing this bug? So far, I've tested this on five windowsXP machines and all show this bug.
Can somebody confirm this is broken again so it can be reopened? Also, this was broken again at the same date that bug 234116 appeared.
WFM with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20040216 Firefox/0.8.0+ No JS errors either.
Confirming comment #164 This bug should be reopened. It only appears when not selecting anything on the bookmark context menu (by clicking anywhere else), which was the previous workaround. The bug is definately back, others are confirming as well in http://forums.mozillazine.org/viewtopic.php?p=386602 Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7a) Gecko/20040216 Firefox/0.8.0+ Was there a backout or a new fix of some sort checked in? Bugs 234116 and 232707 seem somewhat related and are relatively new.
If this reappeared due to an unrelated issue it should absolutely NOT be reopened. File a new bug, comment here.
Bug 234717 has been filed on this. Comment there.
Comment on attachment 129573 [details] [diff] [review] Closes open bookmark folder menus manually before dispatching a command clear obsolete review request
Attachment #129573 - Flags: review?(hyatt)
*** Bug 214699 has been marked as a duplicate of this bug. ***
No longer blocks: majorbugs
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: