210984 - XPI extensions cannot add entries in the Account Manager tree

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Patrick Brunschwig]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030529
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030529

After a discussion with Scott, I'm trying to better integrate Enigmail into
Mozilla Thunderbird. I want to create an XPI that adds a new pane to the
settings of the tree of each account. Although the whole logic is dynamic (like
smime prooves), the account manager has a limitation that prevents the creation
of extensions that are not part of standard Mozilla. If I want to create an
extension xxx, the account manager seems to expect two files,
chrome://messenger/content/am-xxx.xul and
chrome://messenger/locale/am-xxx.properties. However, if I want to place my
files in these locations, I would have to add them to messenger.jar and
en-US.jar - but that is not the idea of an XPI.

The account manager should either search for am-xxx.xul and am-xxx.properties in
other locations than chrome://messenger/... or upon registration of the pane, an
additional paramater could identify the chrome directory where the pane is
stored, e.g. chrome://enigmail/...

Reproducible: Always

Steps to Reproduce:

Actual Results:  
if am-xxx.xul and am-xxx.properties are not in messenger.jar / en-US.jar, the
subtree of each account contains an empty item, and an empty pane is shown when
clicking on it

Expected Results:  
standard behavior of account manager tree

Comment 1

[Scott MacGregor]

taking

Comment 2

[Scott MacGregor]

Attachment: the fix

Patrick,

You'll just need to add something like the following to your account manager
extension JS file:

PGPService.prototype.name = "pgp";
PGPService.prototype.chromePackageName = "pgp-mime"; 

That will make the account manager expect the following files:
That will expect these files

chrome://enigmail/content/am-pgp.xul and
chrome://enigmail/locale/am-pgp.properties

Comment 3

[Scott MacGregor]

typo on the chrome urls:

chrome://pgp-mime/content/am-pgp.xul and
chrome://pgp-mime/locale/am-pgp.properties 

given my earlier example.

Comment 4

[Scott MacGregor]

Patrick, I just checked this in. You should be good to go. Let me know if you
have any problems. 

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Scott, you'll most likely want to grep through your patch and change places like:

aExtenstionName

to:

aExtensionName

Comment 6

[Patrick Brunschwig]

works as expected. Thanks Scott!

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Patch to fix 'extenstion' into 'extension'

Comment 8

[Scott MacGregor]

Comment on attachment 127750 [details] [diff] [review]
Patch to fix 'extenstion' into 'extension'

steve thanks for the fix. Just go ahead and check it in.

r/sr=mscott

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

I've checked in the patch.  Leaving as verified FIXED.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 127750 [details] [diff] [review]
Patch to fix 'extenstion' into 'extension'

clearing review request as the patch is checked in

Comment 11

[Patrick Brunschwig]

Is there a way to have this included in Mozilla 1.4.2? This would allow me to
provide the much more advanced versions of Enigmail with per-account settings.