Closed Bug 211105 Opened 21 years ago Closed 21 years ago

advertisement of CRAM-MD5 not always recognize

Categories

(MailNews Core :: Networking: SMTP, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ch.ey, Assigned: ch.ey)

Details

Attachments

(1 file)

In patch to bug 202162 I made a mistake by changing the start offsets for 
m_responseText.Find("CRAM-MD5", PR_TRUE, 8)
and
m_responseText.Find("EXTERNAL", PR_TRUE, 8)

That now leads to only recognize mechanisms CRAM-MD5 and EXTERNAL if they're not
the first one in the AUTH line.
Attached patch patchSplinter Review
Patch to fix this problem.
Attachment #126745 - Flags: review?(bienvenu)
Comment on attachment 126745 [details] [diff] [review]
patch

r=bienvenu - let me know if you want me to check this in.
Attachment #126745 - Flags: review?(bienvenu) → review+
Yes, that would be nice, thanks.
OK, thx for fixing this; I'll check it in the next time I have stuff to check in.
Assignee: sspitzer → ch.ey
fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: