211169 - nsIHelperAppLauncherDialog::ShowProgressDialog unused

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

lxr shows no caller of this function, only declarations/impls

now, this function is the only user of nsProgressDlg.{js,xul}:
http://lxr.mozilla.org/seamonkey/search?string=nsprogressdlg

so that can be removed as well

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 126823 [details] [diff] [review]
patch

r=me assuming you tested carefully and can still get a progress dialog when
downloading files or opening them in helpers... ;)

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 126823 [details] [diff] [review]
patch

bz: Yes, I did verify that I still get progress windows :)

Comment 4

[Darin Fisher]

Comment on attachment 126823 [details] [diff] [review]
patch

sr=darin

are you sure someone didn't intend to use this for something?  IOW, is this
really dead code?  perhaps it would be wise to drop a line to whomever added
this code to the tree.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

well this dialog was used once:
1.61 	law%netscape.com	May 3 2001	 	Bug 52454; fix lots of external app service
bugs and enable new helper app dlg; r=[e-mail], sr=[e-mail]
(law was also the one who initially checked in nsProgressDlg)

This checkin changed it so that ->ShowProgressDialog (and therefore
nsProgressDlg) was no longer used:
1.131	law%netscape.com	Feb 20 2002	 	Bug 27609; change exthandler to use new
progress dialog and properly report i/o errors; r=bzbarsky, sr=mscott

In this context, see bug 27609 comment 47:
[...] (the ones named nsProgressDlg.* are obsolescent) [...]

So, the author of this code knew all about this.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in.

Comment 7

[S Woodside]

Um, this seems to have killed the camino build.

src/embedding/CHBrowserService.mm:294: no `nsresult
CHBrowserService::ShowProgressDialog(nsIHelperAppLauncher*, nsISupports*)'
member function declared in class `CHBrowserService'

Comment 8

[Boris Zbarsky [:bzbarsky]]

Checked in same removal change to camino/src/embedding/CHBrowserService.mm
(which SeaMonkey lxr does not show).  I left
chimera/src/embedding/CHBrowserService.mm be, since it should be obsolete (and
is a closed CVS partition anyway).

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

oh, right... I'm really sorry about that, I only checked seamonkey lxr. bz,
thanks for fixing!