Closed
Bug 211195
Opened 23 years ago
Closed 23 years ago
[FIX]GetFocusControllerForDocument should not return raw addrefed ptr
Categories
(Core :: DOM: UI Events & Focus Handling, defect, P3)
Core
DOM: UI Events & Focus Handling
Tracking
()
RESOLVED
FIXED
mozilla1.5alpha
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
3.81 KB,
patch
|
bryner
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
It should return already_AddRefed<nsIFocusController>.
|
Assignee | |
Comment 1•23 years ago
|
||
|
|
Assignee | |
Updated•23 years ago
|
Priority: -- → P3
Summary: GetFocusControllerForDocument should not return raw addrefed ptr → [FIX]GetFocusControllerForDocument should not return raw addrefed ptr
Target Milestone: --- → mozilla1.5alpha
|
|
Assignee | |
Updated•23 years ago
|
Attachment #126803 -
Flags: superreview?(bryner)
Attachment #126803 -
Flags: review?(bryner)
|
|
||
Comment 2•23 years ago
|
||
Comment on attachment 126803 [details] [diff] [review]
Proposed change
r/sr=me
Attachment #126803 -
Flags: superreview?(bryner)
Attachment #126803 -
Flags: superreview+
Attachment #126803 -
Flags: review?(bryner)
Attachment #126803 -
Flags: review+
|
|
Assignee | |
Comment 3•23 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
For this kind of thing, why not just return a raw pointer and let the caller
addref if they want? Like we're doing with nsIFrame::GetContent() etc?
|
|
Assignee | |
Comment 5•23 years ago
|
||
In this case, that would involve calling an XPCOM getter and then releasing the
pointer it gave you before returning it, unless I also changed the nsPIDOMWindow
interface... I could do that, I suppose, but I wasn't sure that was desired in
the first place -- jst does not seem to like things returning weak pointers much....
I see, thanks.
|
||
Updated•7 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•