211263 - DomainPolicy::DomainPolicy doesn't check the return value of PL_DHashTableInit

Status: VERIFIED FIXED

(Core :: Security: CAPS, defect)

Description

[timeless]

This is a code inspection bug.

QA:
To verify that this bug is fixed, make sure that all callers in of 
PL_DHashTableInit in the indicated class/file check and handle a failure return 
result.
To verify that this bug is invalid, simply verify (e.g. with lxr) that 
PL_DHashTableInit is no longer used by the indicated class/file.

PL_DHashTableInit returns a PRBool indicating whether it succeeded. 
PL_DHashTableInit *can* fail. Code can not assume that table->ops or table-
>data will be null (in fact it probably will not be), although in all 
likelyhood table->entryStore will be null it probably isn't safe to assume this.

Code at time of bug filing:

 211 class DomainPolicy : public PLDHashTable
 212 {
 213 public:
 214     DomainPolicy() : mWildcardPolicy(nsnull),
 215                      mRefCount(0)
 216
 217     {
 218         static PLDHashTableOps domainPolicyOps =
 219         {
...
 229         };
 230
 231         PL_DHashTableInit(this, &domainPolicyOps, nsnull,
 232                           sizeof(ClassPolicy), 16);
 233     }

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Fixed by checkin to bug 83536.

Comment 2

[timeless]

vrfy fixed