211266 - void nsHTMLEntities::AddRefTable doesn't check the return value of PL_DHashTableInit

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[timeless]

This is a code inspection bug.

QA:
To verify that this bug is fixed, make sure that all callers in of 
PL_DHashTableInit in the indicated class/file check and handle a failure return 
result.
To verify that this bug is invalid, simply verify (e.g. with lxr) that 
PL_DHashTableInit is no longer used by the indicated class/file.

PL_DHashTableInit returns a PRBool indicating whether it succeeded. 
PL_DHashTableInit *can* fail. Code can not assume that table->ops or table-
>data will be null (in fact it probably will not be), although in all 
likelyhood table->entryStore will be null it probably isn't safe to assume this.

Code at time of bug filing:

 134 void
 135 nsHTMLEntities::AddRefTable(void)
 136 {
 137   if (++gTableRefCnt != 1)
 138     return;
 139
 140   PL_DHashTableInit(&gEntityToUnicode, &EntityToUnicodeOps,
 141                     nsnull, sizeof(EntityNodeEntry),
 142                     PRUint32(NS_HTML_ENTITY_COUNT / 0.75));
 143   PL_DHashTableInit(&gUnicodeToEntity, &UnicodeToEntityOps,
 144                     nsnull, sizeof(EntityNodeEntry),
 145                     PRUint32(NS_HTML_ENTITY_COUNT / 0.75));

Comment 1

[timeless]

Attachment: proposal one

Comment 2

[timeless]

.

Comment 3

[Axel Hecht]

Comment on attachment 133953 [details] [diff] [review]
proposal one

r=[e-mail], though I personally prefer to add the early return back. Even
if that means to increment the refcount at two different places.
Heikki's call.

Comment 4

[timeless]

checked in