211291 - void nsCertTree::InitCompareHash doesn't check the return value of PL_DHashTableInit

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[timeless]

This is a code inspection bug.

QA:
To verify that this bug is fixed, make sure that all callers in of 
PL_DHashTableInit in the indicated class/file check and handle a failure return 
result.
To verify that this bug is invalid, simply verify (e.g. with lxr) that 
PL_DHashTableInit is no longer used by the indicated class/file.

PL_DHashTableInit returns a PRBool indicating whether it succeeded. 
PL_DHashTableInit *can* fail. Code can not assume that table->ops or table-
>data will be null (in fact it probably will not be), although in all 
likelyhood table->entryStore will be null it probably isn't safe to assume this.

Code at time of bug filing:

 135 void nsCertTree::InitCompareHash()
 136 {
 137   ClearCompareHash();
 138   PL_DHashTableInit(&mCompareCache, &gMapOps, nsnull,
 139                     sizeof(CompareCacheHashEntry), 128);
 140 }

Comment 1

[timeless]

Attachment: patch

Comment 2

[Kai Engert [:KaiE:]]

Comment on attachment 128529 [details] [diff] [review]
patch

r=kaie
Thanks for the patch

Comment 3

[timeless]

checked in