211378 - Unable to paste into editor widgets with middle mouse button

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:
1)  Start a mail compose window
2)  Select some text somewhere (elsewhere in Mozilla, another app, does not
    matter) 
3)  Middle-click in the mail composition area

EXPECTED RESULTS:  text is pasted
ACTUAL RESULTS: nothing happens

FURTHER DETAILS:  The problem occurs with both HTML and plaintext composition. 
Middle-mouse-paste into one-line textfields and HTML textareas works fine. 
Middle-mouse-paste into Composer does NOT work (hence the choice of component).
 There are no errors in the JS console; no warnings or assertions in a debug
build.  Pasting via Ctrl-C works fine; it's just middle-clicking that fails.

I looked over the checkins made in that time period, and nothing jumps out at
me... ccing people most likely to have something at all to do with this.

Comment 1

[Andrew Schultz]

regressed between trunk 2003062405 and 2003062505

Comment 2

[Greg Onufer]

This is a dup of older bug 210775.

Comment 3

[Boris Zbarsky [:bzbarsky]]

*** Bug 210775 has been marked as a duplicate of this bug. ***

Comment 4

[Frank Wein [:mcsmurf]]

*** Bug 211866 has been marked as a duplicate of this bug. ***

Comment 5

[Frank Weberskirch]

Reproduced also with 
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5a) Gecko/20030706

Comment 6

[Hartmut Figge (don't use this one, it's defunct!)]

I had noticed this bug under linux with 20030702 and 20030703, now i am back to
20030611 because this bug makes Mozilla useless for me.

Comment 7

[Boris Zbarsky [:bzbarsky]]

OK, this makes editor/composition basically unusable...

Comment 8

[Boris Zbarsky [:bzbarsky]]

OK, I locally backed out glazou's big positioning patch and that fixed this bug.
 I can't find a bug number attached to that checkin, so can't very well read a
diff; no clue what in that huge thing is responsible.

Comment 9

[Mitch]

Boris, can you point us to glazou's patch you backed out please since i'm stuck
on 20030611 until this gets resolved.

Comment 10

[Boris Zbarsky [:bzbarsky]]

There is no diff or bug involved, as comment 8 says.  The relevant checkins are
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=glazman%25netscape.com&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2003-06-24+05%3A00%3A00&maxdate=2003-06-25+05%3A00%3A00&cvsroot=%2Fcvsroot

Note that if you try to back them out via cvs up -j you will get conflicts,
since those files have been modified since.

Comment 11

[kinmoz]

I think what busted things was glazman's addition of
nsHTMLEditorMouseListener::MouseClick() ... it doesn't call through to the base
class equivalent like some of the other nsHTMLEditorMouseListener related
callbacks do ... I think this can be fixed by making this change in
nsHTMLEditorMouseListener::MouseClick():


-  return NS_OK;
+  return nsTextEditorMouseListener::MouseClick(aMouseEvent);


I'm thinking the code in nsHTMLEditorMouseListener::MouseClick() should be
checking what button was actually clicked before calling the
DoInlineTableEditingAction() code, but I'll leave that up to glazman to address.

Comment 12

[kinmoz]

Attachment: Patch Rev 1 (Call thru to base class version of MouseClick())

bz says the patch fixed things for him. Here's a formalized patch for review
purposes.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 127187 [details] [diff] [review]
Patch Rev 1 (Call thru to base class version of  MouseClick())

sr=me

Comment 14

[Hartmut Figge (don't use this one, it's defunct!)]

Just fetched new source from cvs, applied the patch, compiled and mozilla didn't
even start up. Oh well, that's cvs.
Then i aplied the patch to the  source from 20030702 and the bug was gone.

Comment 15

[Kathleen :Brade]

Comment on attachment 127187 [details] [diff] [review]
Patch Rev 1 (Call thru to base class version of  MouseClick())

r=brade; for correctness, shouldn't we fix MouseUp too?

Comment 16

[kinmoz]

Attachment: Patch Rev 1.1 (Call thru to base class version of MouseUp() and MouseClick())

I didn't bother with MouseUp() because it does absolutely nothing (it's a stub)
but brade's right, it could change someday so it may be a bug waiting to
happen?

Here's a patch that adds MouseUp(). Hope you guys don't mind, I'm rolling
forward the reviews. I'll land the patch today when the tree opens.

Comment 17

[kinmoz]

Taking bug for patch checkin.

Comment 18

[kinmoz]

Patch Rev 1.1 checked in on the TRUNK:

  mozilla/editor/libeditor/html/nsHTMLEditorMouseListener.cpp  revision 1.12

Fix should appear in 07/09/03 QA/daily builds.

FYI, glazman's patch that bz mentions above was for bug 137092.

Comment 19

[Mitch]

Excellent. Appears to be fixed. Can someone with knowledge of the selection 
code and the editor widget also checkout wheteher glazou patch was responsible
for bug 210110 ?

Comment 20

[Frank Weberskirch]

Works with 
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030718