211432 - Building without XUL is busted.

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Doug Turner (:dougt)]

Apparently, ApplyTransparencyBitmap is declared and used outside of the MOZ_XUL
#define, but is defined in a MOZ_XUL #define.

Patch forthcoming.

Comment 1

[Doug Turner (:dougt)]

Attachment: moves ApplyTransparencyBitmap

Comment 2

[Christopher Blizzard (:blizzard)]

Comment on attachment 126913 [details] [diff] [review]
moves ApplyTransparencyBitmap

r+sr=blizzard

Comment 3

[Boris Zbarsky [:bzbarsky]]

Shouldn't the body of that method still be inside #ifdef MOZ_XUL?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think it would be best to just add an empty prototype for #ifndef MOZ_XUL
alongside the one for ResizeTransparencyBitmap, here:
http://lxr.mozilla.org/seamonkey/source/widget/src/gtk/nsWindow.cpp#4278

That's what I should have done, sorry.

Comment 5

[Doug Turner (:dougt)]

Even smaller.

Index: nsWindow.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/gtk/nsWindow.cpp,v
retrieving revision 1.405
diff -u -r1.405 nsWindow.cpp
--- nsWindow.cpp        11 Jun 2003 18:15:33 -0000      1.405
+++ nsWindow.cpp        2 Jul 2003 20:53:50 -0000
@@ -4275,6 +4275,7 @@
 }

 #ifndef MOZ_XUL
+void nsWindow::ApplyTransparencyBitmap() {}
 void nsWindow::ResizeTransparencyBitmap(PRInt32 aNewWidth, PRInt32 aNewHeight) {
 }
 #else

Comment 6

[Doug Turner (:dougt)]

Checking in widget/src/gtk/nsWindow.cpp;
/cvsroot/mozilla/widget/src/gtk/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.406; previous revision: 1.405
done

roc's proposed fix checked in.