211440 - BGCOLOR does not work without a # char in the color code on table which is output dynamically using getElementByID function and innerHTML property

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[maad]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624

In the page at http://noby.cubicproductions.com/bugzillatest/, all three tables
should appear in green. Two of them are dynamically output, one is static. The
code for the first table and the third table are identical except that the first
is being output by javascript to a DIV tag. The only difference between the two
dynamically output tables is that one does not contain a # in the color code. In
Mozilla, the first table is displayed with no explicit background color (it
should be green).

Reproducible: Always

Steps to Reproduce:
1. Write a standard HTML table with one TD in it. Using BGCOLOR, set the
background color to, say, green 00FF00. Omit the # character from the color code.
2. Write this table to a div tag using getElementById and innerHTML.
3. Launch Mozilla, view the output. 
Actual Results:  
The table did not have a background color.

Expected Results:  
The table should have appeared as it does if it is statically output (versus
output by javascript). It should have appeared with a background color.

This happens on a couple other copies of Mozilla, all 1.4 and all on Windows XP
systems. Not sure about any other platforms/etc.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: patch

We have to pass the right document in; otherwise we get standards-mode parsing
for fragments....

Comment 2

[Boris Zbarsky [:bzbarsky]]

taking.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 126935 [details] [diff] [review]
patch

already_AddRefed<nsIDocument> nsGenericElement::GetOwnerDocument() would indeed
be useful :-)

sr=jst

Comment 4

[John Keiser (jkeiser)]

Comment on attachment 126935 [details] [diff] [review]
patch

r=me, though I'd rather prefer that logic be in a helper function too ... r=me
as well if you want to do GetOwnerDocument()

Comment 5

[John Keiser (jkeiser)]

Comment on attachment 126935 [details] [diff] [review]
patch

r=me, though I'd rather prefer that logic be in a helper function too ... r=me
as well if you want to do GetOwnerDocument()

Comment 6

[Boris Zbarsky [:bzbarsky]]

Bug 211634 filed on the GetOwnerDocument thing -- I'd like to make that a
tree-wide sweep as I do it.

Patch checked in.