211446 - Unlocalizeable texts

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Pavel Cvrcek (inactive account - please use [e-mail])]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows 98)
Build Identifier: 

1) Name of default calendar ("My Calendar") cannot be localized.

2) resources/content/importExport.js

...
const filterCalendar    = "Calendar Files";
const filtervCalendar    = "vCalendar Files";
const filterXcs         = "iCalendar XML Document";
const filterXml         = "XML Document";
const filterRtf         = "Rich Text Format (RTF)";
const filterHtml        = "HTML Files";
const filterCsv         = "Comma Separated";
const filterOutlookCsv  = "Outlook Comma Separated";
const filterRdf         = "iCalendar RDF";
...

(it cannot be localized)

and

...
fp.init(window, "Open", nsIFilePicker.modeOpenMultiple);
...
fp.init(window, "Save As", nsIFilePicker.modeSave);
....

"Open" - it cannot be localized
"Save As" - it cannot be localized


3) resources/content/localCalDialog.js

...
const filterCalendar    = "Calendar Files";
fp.init(window, "Save", nsIFilePicker.modeSave);
...

"Calendar Files" - it cannot be localized
"Save" - it cannot be localized


4) resources/content/calendar.js

var TitleText = document.createTextNode( "Title: "+toDoItem.title );
var DateText = document.createTextNode( "Start 
Date: "+gCalendarWindow.dateFormater.getFormatedDate( startDate ) );
DateText = document.createTextNode( "Due 
Date: "+gCalendarWindow.dateFormater.getFormatedDate( dueDate ) );
var text = "Description: "+toDoItem.description ;

"Title", "Start Date: ", "Due Date" and "Description" - it cannot by localized


5) resources/content/calendarEvent.js

...
if ( calendarEvent.alarmEmailAddress )
{      
var EmailBody = "Calendar Event Alarm Went Off!\n----------------------------
\n";
EmailBody += "Title: "+calendarEvent.title + " at " + 
calendarEvent.start.toString() +  "\n";
EmailBody += "This message sent to you from the Mozilla 
Calendar.\nhttp://www.mozilla.org/projects/calendar/";
//send an email for the event
sendEmail( "Mozilla Calendar Alarm: "+calendarEvent.title, EmailBody, 
calendarEvent.alarmEmailAddress, null, null, null, null );
}
...

it cannot be localized


6) resources/content/unfinder.js

...
var TitleText = document.createTextNode( "Title: "+calendarEvent.title );
...
var DateText = document.createTextNode
( "Start: "+gCalendarWindow.dateFormater.getFormatedDate( startDate )
+" "+gCalendarWindow.dateFormater.getFormatedTime( startDate ) );
...
DateText = document.createTextNode
( "End: "+gCalendarWindow.dateFormater.getFormatedDate( endDate )
+" "+gCalendarWindow.dateFormater.getFormatedTime( endDate ) );
...
var DescriptionText = document.createTextNode
( "Description: "+calendarEvent.description );
...

"Title", "Start", "End" and "Description" - it cannot be localized


7) resources/content/unfinderToDo.js

var TitleText = document.createTextNode( "Title: "+toDoItem.title );
var DateText = document.createTextNode( "Start 
Date: "+gCalendarWindow.dateFormater.getFormatedDate( startDate ) );
DateText = document.createTextNode( "Due 
Date: "+gCalendarWindow.dateFormater.getFormatedDate( dueDate ) );
var text = "Description: "+toDoItem.description ;

"Title", "Start Date", "Due Date" and "Description" - in cannot be localized


8) resources/content/alertDialog.js

TooManyDesc.setAttribute( "value", "You have "+ (gAllEvents.length )+" total 
alarms. We've shown you the last 10. Click Acknowledge All to clear them 
all." );

It cannot be localized. 

This file (alertDialog.js) contain more texts which cannot be localized.


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Eric Belhaire]

I take it and I will propose a patch.

Comment 2

[Eric Belhaire]

Attachment: modified code and en-US locale files

In this patch, I changed the way the properties files are read in the main
files in calendar. srGetStrBundle has been replaces by a declaration in XUL to
allow the use of getFormattedString. It could be that another function which
replace GetStringFromName could be used (FormatStringFromName ??? I did not
found enough information on this fonction). The use of getFormattedString is
really important to let the formatting of the text message in the
module.properties file. This should allow a better translation of Calendar
messages.

I hope I did not broke too much the code with this patch.

Comment 3

[Mike Potter]

Checked into cvs.

Comment 4

[Eric Belhaire]

It seems that you did not include all the patch in CVS. At least the 
file localCalDialog.XUL has not been modify in CVS but it should.

Eric

Comment 5

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!