211476 - Should not depend on internal region struct

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Mac, defect)

Description

[Brian Ryner (not reading)]

nsRegionMac.cpp currently has a dependency on the internal structure of regions,
for nsRegionMac::GetRects().  There's a Carbon API we can use for this that's a
lot cleaner and also not prone to break when Apple decides to change the opaque
region struct.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Use QDRegionToRects() instead of what's there.

Comment 2

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 126945 [details] [diff] [review]
patch

r=pink

Comment 3

[Brian Ryner (not reading)]

checked in.

Comment 4

[Simon Fraser [no longer active]]

File hasn't changed on the 1.4 branch, so backporting to that branch would give
an idential similar patch.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 126945 [details] [diff] [review]
patch

a=dveditz,asa for 1.4.2

Comment 6

[Simon Fraser [no longer active]]

Checked in on the 1.4 branch:
Checking in nsRegionMac.cpp;
/cvsroot/mozilla/gfx/src/mac/nsRegionMac.cpp,v  <--  nsRegionMac.cpp
new revision: 1.24.20.1; previous revision: 1.24