211652 - bookmarks.js fails on QueryInterface for nsIBookmarksService

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P1)

Description

[Paul]

With DEBUG enabled, the following is printed to the console:

JavaScript error: 
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x80570019 (NS_ERROR_XPC_CANT_CREATE_WN) [nsIJSCID.getService]"  nsresult:
"0x80570019 (NS_ERROR_XPC_CANT_CREATE_WN)"  location: "JS frame ::
chrome://communicator/content/bookmarks/bookmarks.js :: initServices :: line
113"  data: no]

I have no idea why this happens, yet, but then, I also have no idea what
NS_ERROR_XPC_CANT_CREATE_WN means

Comment 1

[Paul]

Severity: major : bookmarks no longer work at all under BeOSPriority: P1    : should be fixed ASAPMilestone: 1.5a : should be fixed ASAPThis bug showed its face a couple weeks ago, but I did not pay much attention to it, as Idon't use bookmarks under Mozilla, usually.  It is a major complaint for the 1.4 releasebuilds, causing people to revert to 1.3.I've started researching it a bit more.  The error message, I found out, means it can'twrap the native object around the javascript object, or something like that.  Why it can't, I'm still looking into.  And, why only the bookmark service, I don't know.

Comment 2

[Paul]

Sorry for the SPAM, I knew I shouldn't have use Net+ for posting comments :-(

Severity: major : bookmarks no longer work at all under BeOS
Priority: P1    : should be fixed ASAP
Milestone: 1.5a : should be fixed ASAP

This bug showed its face a couple weeks ago, but I did not pay much attention to
it, as I don't use bookmarks under Mozilla, usually.  It is a major complaint
for the 1.4 release builds, causing people to revert to 1.3.

I've started researching it a bit more.  The error message, I found out, means
it can't wrap the native object around the javascript object, or something like
that.  Why it can't, I'm still looking into.  And, why only the bookmark
service, I don't know.

Comment 3

[Paul]

A little more info I lost in the debug output:

###!!! ASSERTION: This XPCOM object fails in QueryInterface to nsISupports!:
'Error', file xpcwrappednative.cpp, line 228
Break: at file xpcwrappednative.cpp, line 228

Now, I won't pretend to fully understand what is going on with XPCOM.  But, it
seems that the bookmarks server is not registerring itself properly, or not
being looked up properly, for some reason.

If someone could point me in the proper direction as to where/why this is might
be failing, I'd be greatly appreciative.

Comment 4

[Sergei Dolgov]

I have little suspect, that bug is in some way related to profile handling.
(I never used any profile besides default in BeOS, because this feature is
"invisible" for us, while in other OS-es that profile manager popups permanently).
If you know how to create/register user profiles for Mozilla in BeOS, you may
try to create some named profile, and copy there existing bookmarks, to see if
behaviour will be different.
Second thing under my suspects (slightly related to first one) is that we lost
places in bookmark-service or RDF for where bookmarking code must look for
bookmarks and settings, so bookmark-serice partially fails on class Init().

Comment 5

[Paul]

It may be related to profile handling, but I doubt it.  Plus, to have mozilla
start with the profile manager under BeOS:

run-mozilla.sh mozilla-bin -ProfileManager

You can set within the profile manager if you want it to show up all the time or
not. Now, if that doesn't work, it is a bug.
I did try it, just in case, but, as I suspected, no changes.

And, nsBookmarksService does not fail during its Init().  And, it does register
itself with the RDFService.

The problem is, that xpcwrappednative fails on the do_QueryInterface for the
object passed in, which, should be, I think, the BookmarksService.
From what I can tell, it should only fail this, if, it has not had AddRef
called.  Though, I could be completely, and utterly, wrong, as I am now trying
to understand all this stuff, as I never had to figure it out before :-(

Comment 6

[timeless]

Attachment: fix. handle unimplemented contracts

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 127568 [details] [diff] [review]
fix. handle unimplemented contracts

>     if (aAction != "move" && !BookmarksUtils.all(transaction.isValid))
>-      SOUND.beep();
>+      if (SOUND)
>+        SOUND.beep();

How about combining the two ifs into one?

>     var isCancelled = !BookmarksUtils.any(transaction.isValid);
>     if (!isCancelled) {
>       BMSVC.transactionManager.doTransaction(transaction);
>@@ -1355,7 +1361,8 @@
>       } 
>     }
>     if (!BookmarksUtils.all(transaction.isValid))
>-      SOUND.beep();
>+      if (SOUND)
>+        SOUND.beep();


Same.

>     var isCancelled = !BookmarksUtils.any(transaction.isValid);
>     if (!isCancelled) {
>       BMSVC.transactionManager.doTransaction(transaction);
>@@ -1372,7 +1379,8 @@
>     if (!isCancelled) {
>       BMSVC.transactionManager.doTransaction(transaction);
>     } else
>-      SOUND.beep();
>+      if (SOUND)
>+        SOUND.beep();

|else if| on one line

>     return !isCancelled;
>   },

Comment 8

[timeless]

checked in

Comment 9

[timeless]

.

Comment 10

[timeless]

checked in

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 127568 [details] [diff] [review]
fix. handle unimplemented contracts

BeOS build people can take this patch locally but I'm not enthusiastic about
taking serious changes to bookmarks.js into 1.4.1. We don't have the resources
or time to test it well.

Comment 12

[Paul]

I've already applied the patch to the 1.4.0 version available at ftp.mozilla.org.
I will also apply it manually to any other releases that don't specifically
contain it.

Comment 13

[Paul]

Verified that the patch does fix the problem