211657 - [FIXr]Should use '::' for anonymous boxes and other -moz pseudo-elements

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

Filing this per bug 62843 comment 38.  The idea is to fix all the stylesheets
that use this stuff, then stop accepting the single-':' form.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch for the various ::-moz-tree-* pseudos

This patch was generated in a clean tree with the following commands, run from
the mozilla/ dir:

find . -name "*.css" -exec grep -H ":-moz-tree-" {} \; | 
  sed 's/:.*//' | 
  sed 's|^./||' | 
  sort | 
  uniq > ~/fileList.txt

perl -pi -e 's/:-moz-tree-/::-moz-tree-/g' `cat ~/fileList.txt`
cvs diff -u `cat ~/fileList.txt ` > ~/test.patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 127136 [details] [diff] [review]
Patch for the various ::-moz-tree-* pseudos

David, could you review?  The patch itself is pretty unreviewable, but the
procedure I used to generate it is reviwable, of course...

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 127136 [details] [diff] [review]
Patch for the various ::-moz-tree-* pseudos

r+sr=dbaron, although you should probably do toolkit/, browser/, and mail/ as
well.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(You might want to check with hyatt or ben about whether they're happy about
switching to this syntax, though.)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch for toolkit/ using same script

I'll file separate bugs for mail/ and browser/, since I don't have checkin
permission to those, once I hear back from hyatt or ben.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch for all the non-moz-tree pseudo-elements

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 127138 [details] [diff] [review]
Patch for all the non-moz-tree pseudo-elements

There is an edge of some cleanup in nsPresShell.cpp, but it's pretty
straightforward, so I just left it in the diff...

Comment 8

[Brendan Eich [:brendan]]

Re: comment 1, and FYI only (Unix cmd lines were my thing in past lives):

find . -name "*.css" -exec grep -H ":-moz-tree-" {} \; | 
  sed 's/:.*//' | 
  sed 's|^./||' | 
  sort | 
  uniq > ~/fileList.txt
perl -pi -e 's/:-moz-tree-/::-moz-tree-/g' `cat ~/fileList.txt`

would be shorter and possibly much faster if written this way:

find . -name "*.css" -print | xargs grep -l ':-moz-tree-' |
  sed 's|^\./||' |
  sort -u |
  xargs perl -pi -e 's/:-moz-tree-/::-moz-tree-/g'

(find | xargs wins over find -exec; use grep -l, which stops on first match;
combine sort | uniq into sort -u; escape dot in sed r.e. [cosmetic only, not
necessary for correctness]; add perl to the pipeline via xargs).

/be

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 127136 [details] [diff] [review]
Patch for the various ::-moz-tree-* pseudos

hyatt says this is good with him; patch checked in.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch for -moz-tree for browser/

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch for -moz-tree for mail/

Comment 12

[Boris Zbarsky [:bzbarsky]]

Checked in the patches, except the mail/ one.  mscott, could you land that, please?

Comment 13

[Scott MacGregor]

Boris thanks for making a mozilla/mail patch for this. I just checked it in. 

Comment 14

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch to remove support for the single-':' form of -moz pseudos

I'll probably check this in near the end of 1.5b

Comment 15

[Boris Zbarsky [:bzbarsky]]

Attachment: Also bump skinversion

Asa suggested I do this, and it's a good idea.

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 128247 [details] [diff] [review]
Also bump skinversion

Once you land this, make sure you got all of them by checking:
 * LXR
 * your generated chrome.rdf in your chrome/ directory.

Also, these should probably land a bit before the end of 1.5b so we have time
to catch any regressions (e.g., from people landing code they had tested
against older trees, things you missed, etc.).

Have you checked toolkit/, browser/, and mail/ ?  If you haven't, please do...

Comment 17

[Boris Zbarsky [:bzbarsky]]

Attachment: skinversion patch for toolkit/browser

Doh.  I did miss those...  

I guess I'll land this coming Friday or so and that will give me a few days to
sort out issues that may arise before I disappear...

Comment 18

[Boris Zbarsky [:bzbarsky]]

Attachment: mail skinversion patch

Comment 19

[Boris Zbarsky [:bzbarsky]]

Checked in all but the mail/ patches today (I don't have permissions for mail/,
but I dropped mscott an e-mail asking him to check in that part).

Comment 20

[Robert Ginda]

For the record, chatzilla needs to work on *all* versions of mozilla, not just
the latest.  Please keep this in mind when making chatzilla changes in the
future.  I fixed this on the trunk by adding back the ":" versions of these
selectors.  Combining the old and new rules with a comma didn't seem to work,
either, I had to make two distinct rules.

This works on all versions:

treechildren:-moz-tree-image(voice-true) {
    list-style-image: url(chrome://chatzilla/skin/images/is-voice.png);
}

treechildren::-moz-tree-image(voice-true) {
    list-style-image: url(chrome://chatzilla/skin/images/is-voice.png);
}


This didn't...

treechildren:-moz-tree-image(voice-true),
treechildren::-moz-tree-image(voice-true) {
    list-style-image: url(chrome://chatzilla/skin/images/is-voice.png);
}

Comment 21

[Boris Zbarsky [:bzbarsky]]

> Combining the old and new rules with a comma didn't seem to work

That's correct.  If any selector in a comma-separated list is not recognized, 
the whole rule must be dropped, per spec.

Comment 22

[HJ]

"For the record, chatzilla needs to work on *all* versions of mozilla, not just
the latest."

Eh, but the skin number also changed, did I miss anything?

Comment 23

[HJ]

Sorry for this noise but is mozilla's skin number check a strict/exact match?

For example, when I use 1.6 (or higher) as version number in my skin, and use
mozilla 1.5b, does that allow mozilla to startup without errors and to accept
the skin as valid? 

I have no clue as to where I should look for this kind of info (: