211849 - Core and Toolkit should not contain application-specific dependencies

Status: NEW

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

In this checkin, an application-specific #ifdef was added to mozilla/toolkit.
The toolkit should really be application-agnostic. I am working towards the XRE
(super-set of the GRE) which would contain the toolkit (and upon which FB/TB
would be built). When can this "temporary" hack be fixed?

06/08/2003 21:26
scott%scott-macgregor.org
mozilla/ toolkit/ content/ xul.css 	1.24 	  	36/0
We need to make changes to toolkit's autocomplete for it to work in mail compose
(for thunderbird). For now, add an ifdef which rebinds the autocomplete bindings
to the old versions in mozilla\xpfe.

Comment 1

[Pierre Chanial]

I guess mscott used this ifdef to quickly run the new toolkit but I agree that
it should be fixed now. Thought, strictly speaking, this bug does not depends or
blocks bug 213228. The scope of the latter bug is only about not building
xpfe/global before mozilla/toolkit.
Another important thing to do in order to have an application independent
toolkit would be to provide a mechanism to access the specific application name
from the new toolkit (currently brand.dtd and brand.properties in
global/en-US/locale are overwritten when building the stand-alone applications.)

Comment 2

[Serge Gautherie (:sgautherie)]

http://mxr.mozilla.org/mozilla-central/search?string=MOZ_PHOENIX&case=1
"Found 11 matching lines in 8 files"

http://mxr.mozilla.org/mozilla-central/search?string=MOZ_THUNDERBIRD&case=1
"Found 4 matching lines in 4 files"

http://mxr.mozilla.org/mozilla-central/search?string=MOZ_SUITE&case=1
"Found 7 matching lines in 5 files"