212101 - NativeUConvService is built when not needed

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[jag (Peter Annema)]

Right now we unconditionally build the NativeUConvService, but with the
implementation #ifdef'ed out if MOZ_USE_NATIVE_UCONV isn't set. I propose we
skip the whole directory instead. This requires #ifdef'ing one or two places
which currently just #include the header (and then don't do anything with it).

Comment 1

[Stephen Walker]

Attachment: Sprinkle a few ifdefs for the headers

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 141756 [details] [diff] [review]
Sprinkle a few ifdefs for the headers

fine by me assuming it compiles.

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 141756 [details] [diff] [review]
Sprinkle a few ifdefs for the headers

r=mkaply

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 141756 [details] [diff] [review]
Sprinkle a few ifdefs for the headers

a=asa (on behalf of drivers) for checkin to 1.7

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in for 1.7final

Checking in Makefile.in;
/cvsroot/mozilla/intl/uconv/Makefile.in,v  <--  Makefile.in
new revision: 1.18; previous revision: 1.17
done
Checking in src/nsCharsetConverterManager.cpp;
/cvsroot/mozilla/intl/uconv/src/nsCharsetConverterManager.cpp,v  <-- 
nsCharsetConverterManager.cpp
new revision: 1.105; previous revision: 1.104
done
Checking in src/nsCharsetConverterManager.h;
/cvsroot/mozilla/intl/uconv/src/nsCharsetConverterManager.h,v  <-- 
nsCharsetConverterManager.h
new revision: 1.10; previous revision: 1.9
done