Closed Bug 212101 Opened 21 years ago Closed 20 years ago

NativeUConvService is built when not needed

Categories

(Core :: Internationalization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jag+mozilla, Assigned: stdowa+bugzilla)

Details

(Keywords: fixed1.7)

Attachments

(1 file)

Right now we unconditionally build the NativeUConvService, but with the
implementation #ifdef'ed out if MOZ_USE_NATIVE_UCONV isn't set. I propose we
skip the whole directory instead. This requires #ifdef'ing one or two places
which currently just #include the header (and then don't do anything with it).
Attachment #141756 - Flags: superreview?(dougt)
Attachment #141756 - Flags: review?(smontagu)
Comment on attachment 141756 [details] [diff] [review]
Sprinkle a few ifdefs for the headers

fine by me assuming it compiles.
Attachment #141756 - Flags: superreview?(dougt) → superreview+
Attachment #141756 - Flags: review?(smontagu) → review?(mkaply)
Comment on attachment 141756 [details] [diff] [review]
Sprinkle a few ifdefs for the headers

r=mkaply
Attachment #141756 - Flags: review?(mkaply) → review+
Attachment #141756 - Flags: approval1.7?
Comment on attachment 141756 [details] [diff] [review]
Sprinkle a few ifdefs for the headers

a=asa (on behalf of drivers) for checkin to 1.7
Attachment #141756 - Flags: approval1.7? → approval1.7+
Assignee: smontagu → sdwalker
checked in for 1.7final

Checking in Makefile.in;
/cvsroot/mozilla/intl/uconv/Makefile.in,v  <--  Makefile.in
new revision: 1.18; previous revision: 1.17
done
Checking in src/nsCharsetConverterManager.cpp;
/cvsroot/mozilla/intl/uconv/src/nsCharsetConverterManager.cpp,v  <-- 
nsCharsetConverterManager.cpp
new revision: 1.105; previous revision: 1.104
done
Checking in src/nsCharsetConverterManager.h;
/cvsroot/mozilla/intl/uconv/src/nsCharsetConverterManager.h,v  <-- 
nsCharsetConverterManager.h
new revision: 1.10; previous revision: 1.9
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Keywords: fixed1.7
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: