212114 - FormatStatusMessage broken for aStatusArg with more than two args

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[jag (Peter Annema)]

804       PRInt32 pos = args.FindChar('\n', offset);
805       if (pos == -1) 
806         pos = args.Length();
807       argArray[i] = ToNewUnicode(Substring(args, offset, pos));

This should be |Substring(args, offset, pos - offset)|, since the third param is
a length one. For just one arg it'll be fine since offset is 0, and if there are
only two args, |Substring| will just take |NS_MIN(offset + pos
/*args.Length()*/, args.Length())| for the length param. For more than two args
the ones in the middle will go beyond the \n.

Comment 1

[jag (Peter Annema)]

Attachment: Fix oops

Note that the old code |args.Mid(arg, offset, pos)| was doing this incorrectly
too.

Comment 2

[Darin Fisher]

Comment on attachment 127289 [details] [diff] [review]
Fix oops

r=darin

Comment 3

[jag (Peter Annema)]

Checked in.