Closed Bug 212682 Opened 22 years ago Closed 22 years ago

crash when viewing a message with a plugin [nsObjectFrame::ReinstantiatePlugin]

Categories

(Core Graveyard :: Plug-ins, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mscott, Assigned: mscott)

Details

(Keywords: crash)

Attachments

(1 file)

Thunderbird doesn't include plugin support. If I try to view a message which contains a plugin, we crash in nsObjectFrame::ReinstantiatePlugin because of a failure to check for a null window. Adding a null ptr check (which is consistant with other callers of mInstanceOwner->GetWindow) prevents the crash and causes the message to lay out like it should (without the plugin window). Thanks to Darin for reporting this. Patch coming up.
taking
Assignee: peterlubczynski → scott
Keywords: crash
Attached patch the fixSplinter Review
Attachment #127755 - Flags: superreview?(dbaron)
Attachment #127755 - Flags: superreview?(dbaron) → superreview+
fixed
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: