212804 - Enable installation of movemail.rdf on non-AIX systems

Status: RESOLVED FIXED

(MailNews Core :: Movemail, defect)

Description

[Philip K. Warren]

With the checkin for Bug 107833, it is now possible to create a Movemail account
in the account wizard for AIX. I'm opening this bug to enable the installation
by default of movemail.rdf for other UNIX platforms, and also to add the
movemail.rdf file to the correct packages-* files so it is installed with the
installer as well.

Comment 1

[Philip K. Warren]

Taking ownership of bug.

Comment 2

[Philip K. Warren]

Attachment: Patch v1

This builds the movemail.rdf file for all platforms which define MOZ_MOVEMAIL.
In addition, I added the movemail.rdf files to packages-unix and
packages-static-unix so it will be included in the installers as well.

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 127882 [details] [diff] [review]
Patch v1

instead of bin/defaults/isp/movemail.rdf, how about bin/defaults/isp/*?

(and no comment about movemail)

assuming nothing else gets dumped there (aol.rdf or nswebmail.rdf), that should
work.

I think the build system should work fine if there are no isp/* files (or if
there is no isp dir under  bin/defaults), but can you make sure?

I don't want to break the build.

if bin/defaults/isp/* works, and there aren't any problems, r/sr=sspitzer on
that way.

Comment 4

[Philip K. Warren]

Attachment: Patch v2

I don't do defaults/isp/* because I get a glob failed (exit 1) on machines that
don't build movemail as opposed to a harmless warning if I use the full name of
the file. In addition, if I use defaults/isp/* it will also pack
defaults/isp/US/* so we will get duplicate files in the .xpis.

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 129193 [details] [diff] [review]
Patch v2

r/sr=sspitzer

Comment 6

[Philip K. Warren]

Fixed.

Checking in mailnews/base/ispdata/Makefile.in;
/cvsroot/mozilla/mailnews/base/ispdata/Makefile.in,v  <--  Makefile.in
new revision: 1.7; previous revision: 1.6
done
Checking in xpinstall/packager/packages-static-unix;
/cvsroot/mozilla/xpinstall/packager/packages-static-unix,v  <-- 
packages-static-unix
new revision: 1.67; previous revision: 1.66
done
Checking in xpinstall/packager/packages-unix;
/cvsroot/mozilla/xpinstall/packager/packages-unix,v  <--  packages-unix
new revision: 1.272; previous revision: 1.271
done

Comment 7

[Wolfgang Rosenauer [:wolfiR]]

hmm, while checking why my builds don't include movemail.rdf I've noticed that
it seems the file doesn't get installed via "make install".
As "make install" does work otherwise relatively well and I don't understand the
Makefile stuff of mozilla well enough I would like to ask if this could be fixed?

Comment 8

[Philip K. Warren]

(In reply to comment #7)
> hmm, while checking why my builds don't include movemail.rdf I've noticed that
> it seems the file doesn't get installed via "make install".
> As "make install" does work otherwise relatively well and I don't understand the
> Makefile stuff of mozilla well enough I would like to ask if this could be fixed?

Can you please open a new bug for this issue?

Comment 9

[Philip K. Warren]

Bug 281084 filed for the issue in comment 7.