212839 - Tree control used in preferences dialog does not handle collapsing properly

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Kevin Gadd]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030715
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030715

If you open multiple leaves in a tree control (like the one in Preferences), and
scroll down, and then collapse a large leaf, the tree control does not scroll
back up properly, and it displays phantom items (ones that can be selected). The
scrollbar is also gone, so the only way to get rid of them is to expand/collapse
another leaf.

Reproducible: Always

Steps to Reproduce:
1. Open preferences dialog.
2. Open two or three leaves.
3. Scroll down.
4. Collapse a leaf.
Actual Results:  
The tree control scrolled up beyond the top of its items, and displayed phantom
items.

Expected Results:  
Scrolled to the correct location.

Comment 1

[Kevin Gadd]

Attachment: Before collapsing a leaf (after scrolling down)

Comment 2

[Kevin Gadd]

Attachment: After collapsing a leaf

Comment 3

[[e-mail]]

I've got a fix for this in my tree. Unfortunately I don't have my tree...

Comment 4

[Andrew Schultz]

*** Bug 213460 has been marked as a duplicate of this bug. ***

Comment 5

[Andrew Schultz]

this regressed between trunk 2003062005 and 2003062105.

debug build asserts a lot:
###!!! ASSERTION: bad row: 'aRowIndex >= 0 && aRowIndex < mRows.Count()', file
nsXULTreeBuilder.cpp, line 697
###!!! ASSERTION: bad row: 'aIndex >= 0 && aIndex < mRows.Count()', file
nsXULTreeBuilder.cpp, line 573
###!!! ASSERTION: bad row: 'aRow >= 0 && aRow < mRows.Count()', file
nsXULTreeBuilder.cpp, line 540

Comment 6

[[e-mail]]

*** Bug 215799 has been marked as a duplicate of this bug. ***

Comment 7

[[e-mail]]

FYI Mozilla 1.4 initially mispaints the tree, although you need a slow enough
computer to notice before it correctly repains it :-)

Comment 8

[[e-mail]]

Attachment: Proposed patch

Comment 9

[[e-mail]]

Comment on attachment 129726 [details] [diff] [review]
Proposed patch

Fix stops us from invalidating an invisible scrollbar, which sets the maximum
position to negative, thus setting the first visible row negative.

Comment 10

[Jan Varga [:janv]]

Comment on attachment 129726 [details] [diff] [review]
Proposed patch

I just reviewed other patch which contains the same change.
anyway, r=varga

Comment 11

[[e-mail]]

You mean bug 216030? The difference is, this is probably a 1.5 blocker.

Comment 12

[Jan Varga [:janv]]

yep

Comment 13

[rbs]

Comment on attachment 129726 [details] [diff] [review]
Proposed patch

sr=rbs

Does this fix bug 125687 too?

Comment 14

[[e-mail]]

It should fix one cause of those assertions.

Comment 15

[[e-mail]]

Comment on attachment 129726 [details] [diff] [review]
Proposed patch

Requesting 1.5 approval for this fix to a pretty visible bug.

Comment 16

[[e-mail]]

*** Bug 214603 has been marked as a duplicate of this bug. ***

Comment 17

[Asa Dotzler [:asa]]

Comment on attachment 129726 [details] [diff] [review]
Proposed patch

a=asa (on behalf of drivers) for checkin to Mozilla 1.5beta.

Comment 18

[[e-mail]]

Fix checked in.

Comment 19

[Chase Tingley]

*** Bug 169196 has been marked as a duplicate of this bug. ***