212937 - incorrect login <username>@<servername> instead of just <username>

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[Anton Rzheshevski]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.4) Gecko/20030624

When Mozilla sends login info to the POP server, it composes it as
<username>@<server name>
but in my LAN, server is set up differently, and this login does not work!
And, because this is handled only automatically, I can't bypasss it in any way.
I forced to use Outlook although I don't like it :(

Reproducible: Always

Steps to Reproduce:
1.set username to "[e-mail]" (required by LAN administrator)
2.set server name to "mail.internets.ru"

Actual Results:  
Mozilla requests password for "[e-mail]@mail.internets.ru", then
mail.internets.ru server responds "Bad login" because it expected
"[e-mail]", not "[e-mail]@mail.internets.ru".

Attempts to use just "cheb" as username won't help, because then mozilla sends
login "[e-mail]", not "[e-mail]" and server still says
"Bad login".

Expected Results:  
Act as all normal mail clients, and send <username> to log to the server, and
not invent any stupid constructs. 
Because msOutlook works, and TheBat works, only Mozilla fails.

no any firewall.

Comment 1

[Matthias Versen [:Matti]]

"[e-mail]@mail.internets.ru" means that it sent "[e-mail]" as
user to the server "mail.internets.ru".

Can you please create a pop3 log : 
http://www.mozilla.org/quality/mailnews/mail-troubleshoot.html

Comment 2

[timeless]

use about:config and set (boolean) mail.allow_at_sign_in_user_name probably to 
true. Use google and read about it.

Comment 3

[Anton Rzheshevski]

LOG:
0[780160]: Entering NET_ProcessPop3 88
0[780160]: POP3: Entering state: 1
0[780160]: POP3: Entering state: 2
0[780160]: POP3: Entering state: 4
0[780160]: RECV: +OK POP3 crom::pop3d server. Version 3.0
<[e-mail]>
0[780160]: POP3: Entering state: 29
0[780160]: SEND: AUTH

0[780160]: Entering NET_ProcessPop3 22
0[780160]: POP3: Entering state: 3
0[780160]: RECV: -ERR Not implemented
0[780160]: POP3: Entering state: 30
0[780160]: POP3: Entering state: 31
0[780160]: POP3: Entering state: 5
0[780160]: SEND: USER [e-mail]

vvv...the next block repeats 89 times, since I have no choice except endless
clicking "Ok" button in popping up dialog box >:E ...grrrr...

0[780160]: Entering NET_ProcessPop3 5
0[780160]: POP3: Entering state: 3
0[780160]: RECV: +OK
0[780160]: POP3: Entering state: 32
0[780160]: POP3: Entering state: 6
0[780160]: Logging suppressed for this command (it probably contained
authentication information)
0[780160]: Entering NET_ProcessPop3 16
0[780160]: POP3: Entering state: 3
0[780160]: RECV: -ERR Bad login
0[780160]: POP3: Entering state: 7
0[780160]: POP3: Entering state: 24
0[780160]: POP3: Entering state: 0
0[780160]: POP3: Entering state: 31
0[780160]: POP3: Entering state: 5
0[780160]: SEND: USER [e-mail]

^^^...

Comment 4

[Christian Eyrich]

Anton, please look at the log you posted.
Don't you think
SEND: USER [e-mail]
looks absolutely right?

And as Matti said, "[e-mail]@mail.internets.ru" ist only a string
displayed in the dialog and has nothing to do with the string sent (ugly, I know).

There seems to be another problem with your account.
You write, the login and error block repeats 89 times, since you have no choice
except endless clicking "Ok" button in popping up dialog box. What dialog box is
this? It's not the password question?

If the password dialog doesn't appear it looks like you entered your password
and clicked "remember". But since this option only takes effect if the password
entered succeeded I guess your login succeeded at least once in the past.
Ist this right? Please supply as with more details to track this down, thanks.

Comment 5

[Anton Rzheshevski]

>What dialog box is this?
"Alert: The PASS command did not succeed. Mail server mail.internets.ru
responded: Bad login"

>>I guess your login succeeded at least once in the past.
Right. But then something happened with the server (I gues, database failure or
something like this), and Mozilla just stopped working

I think, mail server returns incorrect error code for such situation, and
Mozilla is totally confused by this. It SHOULD ask me for the new password, but
it cries "bad login" instead. :(

Comment 6

[Christian Eyrich]

>>I guess your login succeeded at least once in the past.
Right. But then something happened with the server (I gues, database failure or
something like this), and Mozilla just stopped working

Aha, ok, that explains some issues.

> Mozilla is totally confused by this. It SHOULD ask me for the new password,
but it cries "bad login" instead. :(

No, not confused. This alert is always displayed if a login fails, but it's
followed by the password dialog if the password has not been saved.
I'm about to think over a reorganization of this behaviour to straighten things
and make it easier.

But to get to the point let's see what problem prevends you from getting mail.
I guess the problem is the saved password and not the username (as this looks
good in the log).
So please delete the password: Privacy&Security->Passwords->Manage Stored
Passwords->choose your POP accounts line and remove it.
Then try to get mail again and enter the correct password in the dialog.

Please report if that works.

Comment 7

[David :Bienvenu]

or try tomorrow's build - I fixed the password looping problem.

Comment 8

[WADA:World Anti-bad-Duping Agency]

Attachment: NSPR POP3 protocol log

I was recommended to report here by Christian Eyrich in Bug 213513.

I tested 4 cases with 2003073110-trunk/Win-Me.
(Infinite retry loop has been already resolved by 2003073110-trunk) 

[Case-1]
 Use secure authentication    : Unchecked
 User name in Server Settings : [e-mail] (This is valid username)
 -> "AUTH failed" alert was isseued although valid username/password

[Case-2]
 Use secure authentication    : Checked
 User name in Server Settings : [e-mail] (This is valid username)
 -> Password was prompted although valid username/password
 -> Username on dialog was xxxx@[e-mail]@ops.dti.ne.jp

[Case-3]
 Use secure authentication    : Checked
 User name in Server Settings : xxxx (This is first part of the valid username)

 -> No error.

[Case-4]
 Use secure authentication    : Unchecked
 User name in Server Settings : xxxx (This is first part of the valid username)

 -> No error.

Note-1:
 Both USE/PASS(POP3) and APOP are enabled at POP Server(pop.ops.dti.ne.jp)
Note-2:
 Login was successuful in case-3/case-4 because my real user name has
xxxx@<POP_Server_Name> format fortunately.

Comment 9

[Christian Eyrich]

Thank you WADA for the very detailed log.

Since in the APOP case login including the username is suppressed, let's
concentrate on the not secure authentication.

For Case-2 you say "Password was prompted" while in Case-1 ""AUTH failed" alert
was isseued".
Although that's not the issue of this bug, the user should get both (first the
AUTH failed alert with OK button and then the password prompt dialog) in both cases.
Did you get both and that's a flaw in you description?


Ok, now for the real work.
In Case-2 you wrote, the username prompted in the dialog was
xxxx@[e-mail]@ops.dti.ne.jp. Is this true or was it
[e-mail]@ops.dti.ne.jp? The second @ confuses me.
And what's the servername in your settings - pop.ops.dti.ne.jp, ops.dti.ne.jp or
another?
I think it should be pop.ops.dti.ne.jp but the username in the dialog then
should have been [e-mail]@pop.ops.dti.ne.jp.

I tried to reproduce your results with different settings. I don't know if login
would have succeeded if I had the right password, but the username sent in my
trials was "[e-mail]" instead of "[e-mail]" in
your case.
So it looks right for me under the premise you're right with [e-mail]
is a valid username.

But in the log of Case-4 you can see Mozilla sent
USER muttley
and that was accepted. So it looks to me as the login in this case wasn't
successful because your "real user name has
xxxx@<POP_Server_Name> format fortunately" but the server accepts xxxx only (at
least too) as username.

In Case-4 you can see from the log, that nothing was appended to the username
you entered. That's the same result we saw from Anton's log.

What needs to be explained is the difference between the sent
USER [e-mail]
in your log Case-1 and [e-mail] (I guess [e-mail]) you
wrote you entered in the settings.


Phew, that's a lot stuff. Please go through your settings again and don't
anonymize your username with xxxx (we also know the real one from the log) to
prevend confusion.

Comment 10

[WADA:World Anti-bad-Duping Agency]

Christian, sorry for my mistake and my comfusion.

My real account name is "[e-mail]" as you say.
POP server name setting is "pop.ops.dti.ne.jp" .

For (Case-4) :
My provider changed account name format and my account name was changed from
"muttley" to "[e-mail]" in 2002/05.
I had been believing that old format "muttley" was disabled on the change but my
provider said that they still accepted old format account in usual
authentication(non APOP) service for old user's convienience.
Sorry for my confusion and misunderstandig.

For (Case-1) and (Case-2) :
In (Case-1) and (Case-2), I set User Name in Server Settings as
"[e-mail]" by mistake.
I copy&pasted Serverna Name setting after "muttley@" but I forgot to delete
"pop." portion in this test.
Therefore login failed and it is natural.
Sorry again for my mistakes.

Userid displayed in (Case-2) was, I believe,
"[e-mail]@pop.ops.dti.ne.jp".
This is the problem I wanted to report.
<user_name>@<pop_server_name> format is not appropriate for error message. 

Comment 11

[Christian Eyrich]

Ok, that looks good.
To recapitulate, after setting username to "[e-mail]" instead of
"[e-mail]" logging in works for Case-1 and Case-2. And just
"muttley" works in Case-4.
So you have no functional problems when getting mails, yes?

The last thing I don't fully understand: you say "they still accepted old format
account in usual authentication (non APOP) service". But it looks like it works
with APOP too as in Case-3 getting mail succeeded.

So ok, [e-mail]@pop.ops.dti.ne.jp is indeed ugly but no functional
flaw. IMHO it should be changed (like for SMTP, see bug 90507).
I already made a patch for another bug which included this task (see bug 203099
comment #3) but it didn't make it into the source yet. Getting review has been
quite difficult in the last month(s), but I'll try with a new version soon.

Comment 12

[WADA:World Anti-bad-Duping Agency]

> But it looks like it works with APOP too as in Case-3 getting mail succeeded.
I can not distinguish APOP and USE/PASS from protcol log although I can
understand both login in Case-3 and Case-4 are successufull.
However, I'm sure that I set username "muttley" and checked "Use Secure
Authentication" in Case-3. 
Therefore, truth is : "My provider accepts old format account for APOP too."
Sorry for my many mistakes in both testing and reporting.

> So you have no functional problems when getting mails, yes?
Yes. There is no functional flaw in both USE/PASS and APOP.

I prefer "Enter your password for %1$s logging into %2$s:" to "Enter your
password for %1$s@%2$s:". 
I wait for bug 203099.
Thanks a lot, Christian.

Comment 13

[Christian Eyrich]

Attachment: proposed patch

In contrast to the text for SMTPs password dialog (bug 203099), this one can be
changed without modification to the code itself.

So to get this clarification in and to prevent future misunderstandings I made
this a standalone patch. The new text will be "Enter your password for username
logging into server" instead of "Enter your password for username@server".

Comment 14

[David :Bienvenu]

I'm not crazy about the wording but I'm not sure I have a better alternative.
Perhaps "Enter your password for username on server". Scott, do you have an opinion?

Comment 15

[Christian Eyrich]

That would be ok to me as well.
I suggested the string three months ago in bug 90507 and saw no contrary
proposal. But everything other than the misleading @ is acceptable.

Comment 16

[Christian Eyrich]

Attachment: patch v2

Changed the message to "Enter your password for <username> on <server>".

Comment 17

[Mats Palmgren (inactive)]

*** Bug 218778 has been marked as a duplicate of this bug. ***

Comment 18

[Joe Infla]

*** Bug 141156 has been marked as a duplicate of this bug. ***

Comment 19

[Christian Eyrich]

Scott Vetter, in bug 218778 you wrote "The end result [of appending the
mailserver part to the username] is that I cannot send or receive email."

Do you really have problems to authenticate with the POP server? Did you even
try to enter your password for the username and go on? Or do you just give up
because of this malformed username@servername?

Comment 20

[David :Bienvenu]

Comment on attachment 131140 [details] [diff] [review]
patch v2

r/sr=bienvenu

Comment 21

[David :Bienvenu]

patch checked in, thx, Christian.

Comment 22

[Jeremy M. Dolan]

"(i.e. [e-mail])"

That example expanded string in the comment should probably have been updated,
or removed.

Comment 23

[Christian Eyrich]

*** Bug 65649 has been marked as a duplicate of this bug. ***