213035 - replace NS_ConvertUTF8toUCS2 with IsUTF8 for UTF8-ness checking

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect)

Description

[Jungshik Shin]

This is just to make debugging a bit easy. Currently, NS_ConvertUTF8toUCS2 is
invoked just to check if a string is a valid UTF-8 string. Now that we have
IsUTF8, we'd better use it. With that, we get assertions where invalid strings
are used (in mailnews/mime/src) instead of string/public/nsUTF8Utils.h

Comment 1

[Jungshik Shin]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

How about changing:

#ifdef DEBUG
if (foo)
  NS_ASSERTION(something, "")
#endif

To:

NS_ASSERTION(!foo || something, "");

Comment 3

[Jungshik Shin]

Attachment: simplified patch

Yup, I realized that right after uploading attachment 127994 [details] [diff] [review].

Comment 4

[Jungshik Shin]

Comment on attachment 127996 [details] [diff] [review]
simplified patch

asking for r/sr

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 127996 [details] [diff] [review]
simplified patch

Excellent. sr=me.

Comment 6

[David :Bienvenu]

Comment on attachment 127996 [details] [diff] [review]
simplified patch

yes, thx.

Comment 7

[Jungshik Shin]

Comment on attachment 127996 [details] [diff] [review]
simplified patch

thanks for r.
Now asking for 1.5b.

Risk : zero in opt. build  because I'm just changing  several NS_ASSERTION. 
Benefit : in debug build, assertion will be made where it's supposed to be made
instead of a far-away place(xpcom/string).

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 127996 [details] [diff] [review]
simplified patch

a=asa (on behalf of drivers) for checkin to 1.5beta

Comment 9

[Asa Dotzler [:asa]]

It looks like this landed on 8/26. Can this bug be resolved?

Comment 10

[Jungshik Shin]

sorry for forgetting to mark as resolved.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified fixed using LXR as code inspection.