213053 - Field name for "Company" in the Address Book is different in Address Card and Address Overview window

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Uwe]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624

Address book overview uses field title "Company"  and 
Address Card uses field title "Organization" for same field.

Reproducible: Always

Steps to Reproduce:
1.Create a new address card in address book
2.Type a company name in field "Organization" on the address tab
3. Close card and find address in overview window
4. You can now see your "Organization" entry in "Company" column
Both should have the same title

Actual Results:  
"Organization" name appears in "Compnay" column

Expected Results:  
Both fields "Company" and "Organizaion" should have the same name
i.e. either both titled "Company" or both titled "Organization"

Comment 1

[Mathew McBride]

Able to confirm. I wish to fix this one.

Comment 2

[Mathew McBride]

Attachment: Modifies 'Company' to 'Orginisation'

Fix. What more could I say!

Comment 3

[Mathew McBride]

Message via private mail:
> But then I get:


> XML Parsing Error: syntax error
> Location: http://bugzilla.mozilla.org/attachment.cgi?id=128009&action=view
> Line Number 37, Column 1:<!ENTITY GeneratedName.label                   "Name">
^

You have wait until the next Mozilla release or perhaps Nightly build before
this is completely fixed. If you upgrade to a Mozilla nightly, I can post a
modified jar file. 

sspitzer: review wanted. 

Comment 4

[Mathew McBride]

Attachment: Fix v1.01

Added my name to "Contributor(s):"

Comment 5

[Jo Hermans]

*** Bug 209749 has been marked as a duplicate of this bug. ***

Comment 6

[Andrew Schultz]

Matthew: I assume you are modifying an existing file.  Please generate a patch
(diff) for that file (not sure how to do it in Windows exactly).

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

You set the 'Fix v1.01' to MIME type of 'application/vnd.mozilla.xul+xml'
(either you, or mozilla/bugzilla did that automatically for you).

I've changed it back to 'patch', and it's now viewable inline.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Mathew - do you build Mozilla with either mingW or Visual Studio?

If you already build, you might have the patch utility available from Cygwin.

If so, go to the directory with this fix and type:

cvs diff -u > patchOutputName (.txt or other extension is optional, and
|patchOutputname| can be anything you want).

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

By the way, 'Orginization' is spelled incorrectly.

It should be:

'Organization'

Also, it might make sense to change the XML entities of:

<!ENTITY Company.label                         "Organization">
<!ENTITY Company.accesskey                     "C">

to be:

<!ENTITY Organization.label                    "Organization">
<!ENTITY Organization.accesskey                "O">

(but I'm not sure about the accesskey just yet, and you'd have to change the
references in the corresponding XUL files that use 'Company' to use the new
'Organization'.

I'll let Seth make that call.

Comment 10

[Mathew McBride]

Attachment: patch to mozilla/mailnews/addrbook/resources/locale/en-US/abResultsPaneOverlay.dtd

My mistake. Obsoleting 1.01

We have "organization" defined in two places. Once for the results pane
(abResultsPaneOverlay.dtd) and one for the "create card" screen. 

Perhaps we can create a central file for the words and one for the accesskeys?

Is there any overhead (i.e jar, extracting at load time) in redefining the same
word in different files when we could keep them in one place?

(For company.accessKey, I'll leave that to Seth. This is a minor issue)

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Technically speaking, the patch is fine.

However, Seth should give his position on what to do about the naming of the XML
entities, as well of course, as you mentioned, about the accesskey for Organization.

To answer you other questions:

>Perhaps we can create a central file for the words and one for the accesskeys?

No, this is not common practice at all.

>Is there any overhead (i.e jar, extracting at load time) in redefining the same
word in different files when we could keep them in one place?

Probably little to none, but I'm not sure about the state of XUL fastload (I do
know we fastload our JS presently).  Seth might know more.

Comment 12

[Mathew McBride]

Comment on attachment 130952 [details] [diff] [review]
patch to mozilla/mailnews/addrbook/resources/locale/en-US/abResultsPaneOverlay.dtd

review?. I don't seem to find another occurance of "company" in the address
book locale. We do need to fix the accesskey though.

Comment 13

[Andrew Schultz]

Comment on attachment 130952 [details] [diff] [review]
patch to mozilla/mailnews/addrbook/resources/locale/en-US/abResultsPaneOverlay.dtd

(you need to request review from somebody specifically)

Comment 14

[Gervase Markham [:gerv]]

Assigning to patch author.

Gerv

Comment 15

[(not reading, please use [e-mail] instead)]

Comment on attachment 130952 [details] [diff] [review]
patch to mozilla/mailnews/addrbook/resources/locale/en-US/abResultsPaneOverlay.dtd

r/sr/a=sspitzer for 1.5

thanks for the UI polish

Comment 16

[Mathew McBride]

Thanks. Can someone here with a CVS account check it in?

Comment 17

[(not reading, please use [e-mail] instead)]

we also need to fix the value in the import locale file, and fix that accesskey
(although it might not be used).

new patch coming...

Comment 18

[(not reading, please use [e-mail] instead)]

Comment on attachment 130952 [details] [diff] [review]
patch to mozilla/mailnews/addrbook/resources/locale/en-US/abResultsPaneOverlay.dtd

this patch alone will mess up the View | Sort By menu, since the accesskey
isn't right.

new patch coming.

Comment 19

[(not reading, please use [e-mail] instead)]

Attachment: patch for the trunk

Comment 20

[(not reading, please use [e-mail] instead)]

mscott checked in my patch for me on the trunk.  

I'll go check it into the 1.5 branch.

thanks again, mathew, for the initial patch.

Comment 21

[(not reading, please use [e-mail] instead)]

fixed on both trunk (1.6a) and branch (1.5)

Comment 22

[(not reading, please use [e-mail] instead)]

Comment on attachment 131442 [details] [diff] [review]
patch for the trunk

r/sr/a=sspitzer

Comment 23

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with build 2004-06-06-09 on Windows XP.

It now says 'Organization'.